~kevans/tn40xx-build.diff
Added tn40xx
Changes after first round of tests.
Support FreeBSD 12.x and other fixes
Version 1.1
Bug fix.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Warnings Severity Location Code Message Warning sys/dev/tn40xx/TLK10232_phy.h: CHMOD1 Invalid Executable Warning sys/dev/tn40xx/tn40_mbuf.c: CHMOD1 Invalid Executable - Unit
No Test Coverage - Build Status
Buildable 22776 Build 21868: arc lint + arc unit
Event Timeline
Comment Actions
Most files lack required license and copyright headers. The few that do have them indicate this is GPL licensed which is generally unacceptable for new drivers. Ideally this driver should be licensed under the 2-line BSD or dual licensed under it and the GPL if that is necessary. The complete list of commonly acceptable licenses can be found at https://www.freebsd.org/internal/software-license.html
| sys/conf/files.amd64 | ||
|---|---|---|
| 366 | Is there something amd64 specific about this driver? | |
Comment Actions
A number of files are missing license headers including at least AQR105_phy.c and CX4.c. Please add headers to all source and header files.
The file list should almost certainly be in sys/conf/files not sys/conf/files.amd64.