Page MenuHomeFreeBSD

[new driver] tn40xx: Tehuti networks tn40xx device driver.
AbandonedPublic

Authored by linimon on Feb 27 2019, 1:14 PM.

Details

Reviewers
brooks
ami_tehutinetworks.net
Group Reviewers
Core Team
Summary

~kevans/tn40xx-build.diff

Added tn40xx

Changes after first round of tests.

Support FreeBSD 12.x and other fixes

Version 1.1

Bug fix.

Diff Detail

Lint
Lint WarningsExcuse: These are not executable files.
SeverityLocationCodeMessage
Warningsys/dev/tn40xx/TLK10232_phy.h:CHMOD1Invalid Executable
Warningsys/dev/tn40xx/tn40_mbuf.c:CHMOD1Invalid Executable
Unit
No Unit Test Coverage
Build Status
Buildable 22776
Build 21868: arc lint + arc unit

Event Timeline

Harbormaster completed remote builds in B22776: Diff 54473.
brooks requested changes to this revision.Feb 27 2019, 4:54 PM
brooks added a subscriber: brooks.

Most files lack required license and copyright headers. The few that do have them indicate this is GPL licensed which is generally unacceptable for new drivers. Ideally this driver should be licensed under the 2-line BSD or dual licensed under it and the GPL if that is necessary. The complete list of commonly acceptable licenses can be found at https://www.freebsd.org/internal/software-license.html

sys/conf/files.amd64
366

Is there something amd64 specific about this driver?

This revision now requires changes to proceed.Feb 27 2019, 4:54 PM
linimon retitled this revision from Tehuti networks tn40xx device driver. to [new driver] tn40xx: Tehuti networks tn40xx device driver..Feb 27 2019, 11:34 PM
linimon commandeered this revision.
linimon abandoned this revision.

Superceded by D19433.