Page MenuHomeFreeBSD

shells/xonsh: Upgrade to 0.7.9
ClosedPublic

Authored by roberfern_gmail.com on Sep 21 2018, 7:28 AM.

Details

Reviewers
beat
Commits
rP480240: Upgrade to 0.7.9
Summary

Upgrade of the port to version 0.7.9

Test Plan

manual testing (12.0-ALPHA6) -> ok
poudriere (10.4-RELEASE) -> ok
poudriere (11.2-RELEASE) -> ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

beat added inline comments.Sep 21 2018, 8:28 AM
shells/xonsh/Makefile
13 ↗(On Diff #48297)

Shouldn't it be:
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/license
instead of:
LICENSE_FILE= ${WRKDIR}/license
LICENSE_FILE= ${WRKSRC}/license

mat added inline comments.Sep 21 2018, 8:36 AM
shells/xonsh/Makefile
12–13 ↗(On Diff #48297)

This looks suspicious, if LICENSE is not defined, LICENSE_FILE does nothing.

Removing lines from previous versions

Corrected on another machine and leftovers where kept.

roberfern_gmail.com marked 2 inline comments as done.Sep 21 2018, 8:38 AM

Correcting leftovers from previous attempts. Sorry for that guys.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 21 2018, 8:42 AM
Closed by commit rP480240: Upgrade to 0.7.9 (authored by beat). · Explain Why
This revision was automatically updated to reflect the committed changes.