Page MenuHomeFreeBSD

Avoid completing non-dump I/O requests after a panic.
AbandonedPublic

Authored by markj on May 27 2018, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 15, 11:27 PM
Unknown Object (File)
Fri, May 15, 11:27 PM
Unknown Object (File)
Fri, May 15, 11:26 PM
Unknown Object (File)
Fri, May 15, 11:26 PM
Unknown Object (File)
Fri, Apr 17, 11:54 PM
Unknown Object (File)
Apr 17 2026, 2:45 PM
Unknown Object (File)
Apr 17 2026, 7:25 AM
Unknown Object (File)
Apr 16 2026, 11:09 AM
Subscribers
None

Details

Reviewers
None
Summary

Currently we might call into filesystem or pager code when completing a
non-dump CCB, which typically results in assertion failures or
deadlocks when dumping. D4647 attempted to handle this with a dedicated
CAM doneq, but as was pointed out in the review, that solution may cause
us to fail to unfreeze the device after an error. Try to handle the
problem a different way: filter non-dump CCBs in xpt_done_process(), and
attempt to unfreeze the devq after an error if we're running after a
panic. Stash non-dump CCBs on a list so that they can be inspected
during a debugging session.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16870
Build 16747: arc lint + arc unit