switch nvme driver from make_dev_credf to make_dev_s
ClosedPublic
Actions

Authored by hordijk_netapp.com on Apr 23 2018, 4:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 21, 2:36 PM

	Unknown Object (File)
	Fri, Aug 21, 12:06 PM

	Unknown Object (File)
	Mon, Aug 17, 12:53 AM

	Unknown Object (File)
	Sat, Aug 15, 8:38 PM

	Unknown Object (File)
	Sat, Aug 15, 8:07 PM

	Unknown Object (File)
	Sat, Aug 15, 5:15 AM

	Unknown Object (File)
	Fri, Aug 14, 6:24 PM

	Unknown Object (File)
	Fri, Aug 14, 4:46 PM

View All Files

Subscribers

john.a.meneghini_gmail.com

Details

Reviewers

jimharris
imp

Commits

rS332897: Migrate to make_dev_s interface to populate /dev/nvmeX entries

Summary

Leveraging the newer interface, removing deprecated API.  Also allows us
to remove the redundant check on the cdev entry being non-NULL.

Test Plan

verified /dev/nvme device gets created

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hordijk_netapp.com created this revision.Apr 23 2018, 4:27 AM

Harbormaster completed remote builds in B16260: Diff 41740.Apr 23 2018, 4:27 AM

hordijk_netapp.com added reviewers: jimharris, imp.Apr 23 2018, 4:28 AM

hordijk_netapp.com added a subscriber: john.a.meneghini_gmail.com.

jimharris accepted this revision.Apr 23 2018, 8:47 PM

This revision is now accepted and ready to land.Apr 23 2018, 8:47 PM

Saves us a check at the cost of extra lines :)
this looks good.

Warner - can you commit this to HEAD?

Closed by commit rS332897: Migrate to make_dev_s interface to populate /dev/nvmeX entries (authored by imp). · Explain WhyApr 23 2018, 10:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

nvme/

nvme_ns.c

15 lines

Diff 41784

View Options

head/sys/dev/nvme/nvme_ns.c

switch nvme driver from make_dev_credf to make_dev_sClosedPublicActions