new port: dns/wrapsrv - DNS SRV record command line wrapper
ClosedPublic
Actions

Authored by truckman on Jan 11 2015, 1:54 AM.

Details

Reviewers

mat

Summary

Create new port - dns/wrapsrv

wrapsrv adds support for connecting to a network service based on DNS SRV
record lookups to commands that do not support the DNS SRV record. wrapsrv
implements the weighted priority client connection algorithm in RFC 2782.
The specified command line will be invoked one or more times with %h and %p
sequences in the command line substituted for the hostname and port elements
of the selected SRV record.

Test Plan

Run make describe, portlint, etc.

Use poudriere to build port on FreeBSD 8, 9, and 10, and on amd64 and i386.

Verify ports index build.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

truckman updated this revision to Diff 3096.Jan 11 2015, 1:54 AM

truckman retitled this revision from to new port: dns/wrapsrv - DNS SRV record command line wrapper.

truckman updated this object.

truckman edited the test plan for this revision. (Show Details)

truckman added a reviewer: mat.

mat added inline comments.Jan 11 2015, 2:17 AM

dns/wrapsrv/files/patch-Makefile
30–31	No real need to patch `MAN` and here to gzip the man page, it'll be done automatically during staging, it would reduce the diff a bit :-)

truckman added inline comments.Jan 11 2015, 2:50 AM

dns/wrapsrv/files/patch-Makefile
30–31	> Running Q/A tests (stage-qa) > Checking for pkg-plist issues (check-plist) > Parsing plist > Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/man/man1/wrapsrv.1 > Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: share/man/man1/wrapsrv.1.gz > Error: Plist issues found. Error code 1

truckman added inline comments.Jan 11 2015, 3:58 AM

dns/wrapsrv/Makefile
18	gmake is not needed.

mat added inline comments.Jan 11 2015, 10:52 AM

dns/wrapsrv/files/patch-Makefile
30–31	Ah, yes, man pages are installed in PREFIX/man/man1, not PREFIX/share/man/man1.

Install the man page in the proper location and let it be
automatically gzipped.

mat accepted this revision.Jan 11 2015, 8:14 PM

mat edited edge metadata.

mat added inline comments.

dns/wrapsrv/Makefile
18–19	Maybe the makefile could be patched to run `BSD_INSTALL_PROGRAM` which would strip the binary on install.

This revision is now accepted and ready to land.Jan 11 2015, 8:14 PM

truckman added inline comments.Jan 11 2015, 8:31 PM

dns/wrapsrv/Makefile
18–19	The makefile doesn't include our definitions, so it wouldn't understand BSD_INSTALL_PROGRAM, so it couldn't be done by the patch file. The value could be substituted using ${REINPLACE_CMD}, but I think that's worse than just using ${STRIP_CMD}.