Page MenuHomeFreeBSD

net/nmsg port cleanup
ClosedPublic

Authored by truckman on Jan 10 2015, 8:04 PM.

Details

Reviewers
mat
Summary

MASTER_SITE dl.farsightsecurity.com only allows https downloads.

	  Mirror the distfile on LOCAL as a http backup for clients that
	  can't use https. (Suggested by mat@)

Add MANPAGES option (default YES) because generating the man page
adds a significant number of build dependencies.

Add a comment explaining that the DOXYGEN=NO option gets ignored
if doxygen is installed.

Use option helpers (suggested by mat@).

Use PORTDOCS=* to avoid the need to change pkg-plist if doxygen
changes.

Use INSTALL_TARGET=install-strip instead of ${STRIP_CMD}
(suggested by marino@).

Simplify examples installation.

Test Plan

Test downloads from both MASTER_SITES.

Test all options.

Build on FreeBSD 8, 9, and 10, and both amd64 and i386.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

truckman updated this revision to Diff 3092.Jan 10 2015, 8:04 PM
truckman retitled this revision from to net/nmsg port cleanup.
truckman updated this object.
truckman edited the test plan for this revision. (Show Details)
truckman added a reviewer: mat.
mat accepted this revision.Jan 10 2015, 9:29 PM
mat edited edge metadata.
mat added inline comments.
net/nmsg/Makefile
27–28

Is there a CONFIGURE_ARGS thing you could use, like --disable-docs or something ?

This revision is now accepted and ready to land.Jan 10 2015, 9:29 PM
truckman added inline comments.Jan 10 2015, 9:36 PM
net/nmsg/Makefile
27–28

Nope. There's one for the man page (--without-xsltproc), but nothing for the doxygen stuff. It does look at $DOXYGEN from the environment, but if you set it to '', it falls back to scanning $PATH. I also tried setting it to /bin/false and it took that as the full pathname of the doxygen executable. Configure claimed that it would then use that to build the docs, but I suspect the build would blow up later.

I can try to figure out the autoconf stuff and submit a patch upstream.

In the meantime, disabling the option at least prevents poudriere from dragging in doxygen and all of its dependencies.

truckman closed this revision.Apr 6 2015, 3:39 AM

Closed by commit rP376726 (authored by @truckman).