Flag pending TUR.
ClosedPublic
Actions

Authored by imp on Mar 22 2018, 5:36 AM.

Tags

None

Referenced Files

	F103250300: D14792.diff
	Fri, Nov 22, 3:30 PM

	Unknown Object (File)
	Wed, Nov 20, 1:09 AM

	Unknown Object (File)
	Tue, Nov 19, 8:08 AM

	Unknown Object (File)
	Wed, Nov 13, 12:43 AM

	Unknown Object (File)
	Tue, Nov 12, 8:56 PM

	Unknown Object (File)
	Oct 17 2024, 12:43 PM

	Unknown Object (File)
	Oct 17 2024, 1:27 AM

	Unknown Object (File)
	Oct 15 2024, 3:45 AM

View All 71 Files

Subscribers

hyun_caffeinated.codes

Details

Reviewers

imp

Group Reviewers

cam

Summary

Flag when we have a pending TUR. Don't schedule another one when we
have one pending. Otherwise, we can race and send two, which is
wasteful in close proximity. It can also cause the acaquire/release
count for TUR to be > 1, which is undexpected.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15710
Build 15736: arc lint + arc unit

Event Timeline

imp created this revision.Mar 22 2018, 5:36 AM

Harbormaster completed remote builds in B15709: Diff 40585.Mar 22 2018, 5:36 AM

Spell sc right <doh>!

Harbormaster completed remote builds in B15710: Diff 40586.Mar 22 2018, 5:46 AM

I have tried this diff on r331284 and it still panic when I plug my Transcend microSD reader in. The stack backtrace is exactly same with what I've supplied in the mailing list.

imp accepted this revision.Jul 10 2021, 3:57 PM

This revision is now accepted and ready to land.Jul 10 2021, 3:57 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 10 2021, 3:57 PM

landed as 6a6c0d584479f / r331435

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_da.c

11 lines

Diff 40586

View Options

Flag pending TUR.ClosedPublicActions