malloc failures
Needs ReviewPublic
Actions

Authored by will_worrbase.com on Mar 3 2018, 8:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 29, 12:45 PM

	Unknown Object (File)
	Wed, Apr 29, 9:49 AM

	Unknown Object (File)
	Tue, Apr 28, 5:18 PM

	Unknown Object (File)
	Mon, Apr 27, 3:29 PM

	Unknown Object (File)
	Mon, Apr 27, 10:53 AM

	Unknown Object (File)
	Mon, Apr 20, 12:19 PM

	Unknown Object (File)
	Mon, Apr 20, 3:04 AM

	Unknown Object (File)
	Sun, Apr 19, 7:08 PM

View All Files

Subscribers

imp

Contributor Reviews (src)

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

bsdinstall(8): partedit can hang/crash on read/lseek/malloc failures

This fixes a few problems:

if lseek(2) fails, bootsize underflows to SIZE_T_MAX, making the resulting allocation dangerous
if malloc(3) fails, we end up with a null pointer deref later
if read(2) fails, the installer will hang trying to read(2) boot loader code

Test Plan

Tested via entering the partition editor in bsdinstall

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15351
Build 15406: arc lint + arc unit

Event Timeline

will_worrbase.com created this revision.Mar 3 2018, 8:36 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 3 2018, 8:36 AM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205806

will_worrbase.com retitled this revision from Replace malloc + read in a loop with mmap to bsdinstall(8): partedit can hang/crash on read/lseek/malloc failures.Mar 3 2018, 8:37 AM

will_worrbase.com edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

gpart_ops.c

24 lines

Diff 39912

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

bsdinstall(8): partedit can hang/crash on read/lseek/malloc failuresNeeds ReviewPublicActions