Page MenuHomeFreeBSD

net-mgmt/prometheus1: rc script move and rcvar rename.
AbandonedPublic

Authored by dor on Mar 1 2018, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 28 2024, 7:14 AM
Unknown Object (File)
Feb 24 2024, 12:19 AM
Unknown Object (File)
Nov 29 2023, 11:05 AM
Unknown Object (File)
Nov 26 2023, 6:10 PM
Unknown Object (File)
Nov 23 2023, 3:13 AM
Unknown Object (File)
Nov 21 2023, 12:36 PM
Unknown Object (File)
Nov 21 2023, 10:13 AM
Unknown Object (File)
Nov 11 2023, 12:36 PM
Subscribers

Details

Reviewers
brd
Summary

This PR moves the net-mgmt/prometheus1 rc script to prometheus1 and renames the prefix of its rcvars from prometheus_ to prometheus1_, which allows both net-mgmt/prometheus1 and net-mgmt/prometheus2 to be installed at the same time.

Test Plan
  • Apply this patch to net-mgmt/prometheus1
  • Build and install both net-mgmt/prometheus{1,2}
  • Configure Prometheus 1 to have a different listening port than the default
    • prometheus1_args=--web.listen-address=:<port other than 9090>
  • Start both daemons at the same time.
  • There should be no conflicts between the daemons.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The net-mgmt/prometheus1 maintainer (jevonearth) has previously given his permission for this work to happen on the bug tracker in various Prometheus related discussion. This patch should finalise the move of the old net-mgmt/prometheus to net-mgmt/prometheus1.

A bugzilla issue for this patch exists at: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225620

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Updated diff, generated from an SVN tree at revision 463666 using svn diff -x -U9999.

Previous diff had missed pkg-message.

Regenerated again from the root of the ports tree to get the full path to the files into the diff.

Noticed that start_precmd hadn't been renamed properly. Apologies for the diff spam.