Update devel/yaml-cpp to 0.6.0 and fix downstream ports openxcom and openbmp
ClosedPublic
Actions

Authored by madpilot on Feb 1 2018, 10:07 AM.

Details

Reviewers

AMDmi3
pizzamig

Commits

rP462092: - Update devel/yaml-cpp to 0.6.1

Summary

I'd like to update the devel/yaml-cpp port to the latest version.

The new version dropped the dependency on boost and changed some internal logic.

While testing I discovered games/openxcom and net-mgmt/openbmp need fixes.

openxcom needs adding USE_CXXSTD=c++11 because yaml-cpp includes now require that. I also added missing cmath includes in a few files, I think yaml-cpp includes don't pull that in anymore in those cases.

openbmp lacks an explicit dependency on boost-libs. It was not failing before since yaml-cpp was pulling that in.

Can you review these changes? Thanks.

Test Plan

Tested them in poudriere for supported FreeBSD versions and launched the programs on my machine. All works fine.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

madpilot created this revision.Feb 1 2018, 10:07 AM

Harbormaster completed remote builds in B14724: Diff 38753.Feb 1 2018, 10:07 AM

Herald added a subscriber: mat. · View Herald TranscriptFeb 1 2018, 10:07 AM

madpilot retitled this revision from Update devel/yaml-cpp to 0.6.0 and fix dowwnstream ports openxcom and openbmp to Update devel/yaml-cpp to 0.6.0 and fix downstream ports openxcom and openbmp.Feb 3 2018, 12:22 PM

Updated review to reflect new upstream release with minor changes.

Harbormaster completed remote builds in B14756: Diff 38810.Feb 3 2018, 1:30 PM

net-mgmt/openbmp/Makefile
19 ↗	(On Diff #38810)	I ran some tests and libbost_signals.so is not needed. BTW boost-libs is needed at build time. I'd replace that LIB_DEPENDS line with the following: BUILD_DEPENDS= ${LOCALBASE}/include/boost/exception/all.hpp:devel/boost-libs or similar