Page MenuHomeFreeBSD

ql*_def.h: fix QL_ALIGN parenthesization
ClosedPublic

Authored by rlibby on Oct 14 2017, 7:52 PM.
Tags
None
Referenced Files
F132105246: D12673.id33991.diff
Mon, Oct 13, 6:10 PM
Unknown Object (File)
Sun, Oct 5, 6:11 AM
Unknown Object (File)
Fri, Sep 26, 10:45 PM
Unknown Object (File)
Sep 11 2025, 5:11 PM
Unknown Object (File)
Aug 19 2025, 11:24 AM
Unknown Object (File)
Aug 17 2025, 1:57 PM
Unknown Object (File)
Aug 14 2025, 6:14 AM
Unknown Object (File)
Aug 12 2025, 8:02 PM
Subscribers
None

Details

Summary

QL_ALIGN is a set of copies of roundup2, but it was missing an outer set of parentheses, which began to matter with r324538. Now, fully copy the parenthesization of roundup2.


To add a little more color, I believe r324538 is broken in ql_capture_drvr_state without this. Expression like this

	hdr->rx_state_offset = hdr->tx_state_offset + QL_ALIGN(size, 64);

will yield the wrong result.

The gcc build is also currently broken because of the resulting warning.

Test Plan

buildkernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me. Thanks for the fix.

This revision is now accepted and ready to land.Oct 18 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.