Page MenuHomeFreeBSD

ql*_def.h: fix QL_ALIGN parenthesization
ClosedPublic

Authored by rlibby on Oct 14 2017, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 18, 10:41 AM
Unknown Object (File)
Thu, Sep 17, 12:41 PM
Unknown Object (File)
Mon, Sep 7, 7:06 PM
Unknown Object (File)
Mon, Sep 7, 7:06 PM
Unknown Object (File)
Mon, Sep 7, 7:03 PM
Unknown Object (File)
Mon, Sep 7, 9:07 AM
Unknown Object (File)
Thu, Sep 3, 1:44 PM
Unknown Object (File)
Fri, Aug 28, 7:39 AM
Subscribers
None

Details

Summary

QL_ALIGN is a set of copies of roundup2, but it was missing an outer set of parentheses, which began to matter with r324538. Now, fully copy the parenthesization of roundup2.


To add a little more color, I believe r324538 is broken in ql_capture_drvr_state without this. Expression like this

	hdr->rx_state_offset = hdr->tx_state_offset + QL_ALIGN(size, 64);

will yield the wrong result.

The gcc build is also currently broken because of the resulting warning.

Test Plan

buildkernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me. Thanks for the fix.

This revision is now accepted and ready to land.Oct 18 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.