Page MenuHomeFreeBSD

cam iosched: Schedule cam_iosched_ticker() quanta times per second
ClosedPublic

Authored by fk_fabiankeil.de on Sep 13 2017, 7:02 AM.
Tags
None
Referenced Files
F148242193: D12350.diff
Mon, Mar 16, 6:05 PM
Unknown Object (File)
Sun, Mar 15, 12:08 PM
Unknown Object (File)
Fri, Mar 13, 9:00 AM
Unknown Object (File)
Fri, Mar 13, 5:21 AM
Unknown Object (File)
Sat, Feb 28, 9:15 AM
Unknown Object (File)
Sat, Feb 28, 4:36 AM
Unknown Object (File)
Wed, Feb 18, 6:26 PM
Unknown Object (File)
Tue, Feb 17, 9:44 PM
Subscribers
None

Details

Summary

cam iosched: Schedule cam_iosched_ticker() quanta times per second

Previously callout_reset() was called with a "ticks" value that was off by one.
As a result cam_iosched_ticker() was called a bit too frequently:
On systems with hz=1000 a quanta value of 200 resulted in ~250 calls
and a value of 100 in ~111 calls.

For the "queue_depth" and "bandwidth" limiters the difference
doesn't matter but the "iops" limiter depends on the scheduling
to enforce the correct maximum.

PR: 221956
Obtained from: ElectroBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 20 2017, 9:20 PM
This revision was automatically updated to reflect the committed changes.