Page MenuHomeFreeBSD

devel/boost-*: update to 1.65.1
ClosedPublic

Authored by jbeich on Jul 13 2017, 8:03 PM.

Details

Test Plan
  • poudriere bulk -t devel/boost-all is green on 10.3 i386/amd64, 11.0 i386/amd64, 11.1 armv6/aarch64, 12.0 amd64
  • poudriere bulk -f boost-consumers.list on 11.0 amd64 has only 10 failures
  • -exp run to be tracked in bug 220714

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich added 1 blocking reviewer(s): office.
jbeich edited the test plan for this revision. (Show Details)
  • Fix addr2line detection sometimes failing

Oops, test executable bit to better mimic system() check

This comment was removed by rfyu28uyeg_snkmail.com.
devel/boost-libs/files/patch-libs_stacktrace_build_has__addr2line.cpp
35 ↗(On Diff #30878)

If you are testing for executable permission (not the same as actually executable for the current architecture, of course), should this be X_OK?

rleigh_codelibre.net added inline comments.
devel/boost-libs/files/patch-boost_stacktrace_detail_collect__unwind.ipp
14 ↗(On Diff #32311)

The unconditional undefinition of _GNU_SOURCE breaks builds with some glibc versions if you're planning to upstream the patch, e.g. with CentOS 7. It would be nicer to check if it's defined, and then only undefine if not already defined to preserve the state.

jbeich retitled this revision from devel/boost-*: update to 1.65.0 to devel/boost-*: update to 1.65.1.
  • Update to 1.65.1
  • Guard temporary _GNU_SOURCE to unbreak on GNU systems
  • Guard _URC_NO_REASON to unbreak GCC build on armv6
jbeich set the repository for this revision to rP FreeBSD ports repository.
This revision was automatically updated to reflect the committed changes.