Page MenuHomeFreeBSD

Extend pr_allow flags to 64bit
ClosedPublic

Authored by netchild on Jul 2 2017, 6:03 PM.

Details

Summary

Change pr_allow from 32bit to 64bit. I looked at some places in the two files
and it looks to me like all the places are already 64bit safe (or uses already 64bit).
I did not check other files for the use of the structure, but I have a kernel up and running
with this change. As a test I (re-)added the kmem_allow flag (which I would like to add without
the userland part (the revert of this last time was because of the user interface of the
uerland part, not about the feature itself), and this works.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

netchild created this revision.Jul 2 2017, 6:03 PM
jamie edited edge metadata.Jul 2 2017, 6:49 PM

It has only exhausted 16 bits, no? I would think if you added the flag but left pr_allow as plain "unsigned" your kernel would still work.

netchild updated this revision to Diff 30374.Jul 3 2017, 8:48 PM

Keep it at 32bits, only extend the defines to cover visually 32bits instead of only 16 (and keep
the new flag).

jamie accepted this revision.Jul 3 2017, 8:53 PM
This revision is now accepted and ready to land.Jul 3 2017, 8:53 PM