HomeFreeBSD

Be consistent about functions being static.

Description

Be consistent about functions being static.
Fix misindentation.

Spotted by: DARPA & NAI Labs.

Details

Provenance
phkAuthored on Oct 16 2002, 10:14 AM
Parents
rGc7e1894e95e0: Be consistent about functions being static.
Branches
Unknown
Tags
Unknown

Event Timeline

chenguang.wang_terapines.com added inline comments.
/sys/gnu/ext2fs/ext2_vnops.c
1104–1107

If the source file is a directory and the target file exists, I don't think (newparent == 0) will happen.
Even if this case happens, dp represents the target directory, not the parent of the target directory.

The above conclusion is based on the test results of FreeBSD-13.0, I don't know whether it is correct.
I would be very grateful if someone could help answer this question!

I am not able to review this patch, sorry.