In principle this only changes the user side setup (rc.conf), not the ports side. There is no direct ports consumer of this feature and it tries to hook into all services in order to automate configuration changes when service commands are dispatched.

In my work for the automatic service jails (committed last week), I stumbled upon cases (in the base system) where some kind of functions were used to setup variables before starting the actual service, which was not necessary. When the automatic service jail is enabled for such a service, some of this stuff was run outside the service jail and didn't had the desired effect. After changing those scripts to not setup variables like that, it worked.

In D36259#1035544, @franco_opnsense.org wrote:

This won't merge, I'm talking to @imp at https://github.com/freebsd/freebsd-src/pull/1258

Yes I just need to wrap up testing for the updated GH PR

Oh and I was going to try merge it :P
So we can close this review?

This won't merge, I'm talking to @imp at https://github.com/freebsd/freebsd-src/pull/1258

Was committed (tag was Differential not Differential Revision so it did not auto-close).

@0mp if you put just the short version of the review (D38344) Phab will show if its closed or still open. With that change committed there is presumably no reason for this change any longer?

No takers? This has been in a half-working state in FreeBSD 14 for quite some time. :/

That's the way how DragonFlyBSD devs solved the problem
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/451640b7cf6bcf7826b901ac9a51647442adb96b

Add SPDX BSD-2-Clause to safe_eval.sh

Use local.rc.subr rather than rc.subr.local

Validate load_rc_config_reader

Implement some feedback

Update doc in debug.sh

rc.subr add comment explaining the no-op Debug{On,Off} and safe_dot
at the end - in case the real ones could not be found.

Tweak debug.sh.8, use .Fn when refering to functions called.

Man page tweaks

Add man page for debug.sh

Further man page tweaks

Make a start on man pages

Fix some style issues in rc.subr

Will have a go at the style issues.

The comments for rc.subr also apply to the new files.
What about a man page update how to turn on the debug feature? To my current understanding DEBUG_SH can be set interactively in the loader, and administratively in loader.conf... maybe also in rc.conf? So more than one man page to touch at least with a cross-ref.

Check for -f as well as -s

This is overcome by D43671

Note: If the format of rc_log is deemed undesirable we could move it (and rc_trace) to rc.subr.local and just put a place holder in rc.subr

I know a few folk are interested in using mac_veriexec, but we could push the guts of vdot etc into rc.subr.local (I've moved it to the end of the file) and just put a place holder here like vdot() { dot "$@"; }. It is the callouts in run_rc_* etc which are most important.

Resigning from this; I tried to provide feedback over IRC, but that was seemingly not well-received (and questions unanswered) and I'm not interested in reviewing this as-is. I'd much prefer splitting it into two scripts, one with, e.g., verbs, that manages wireguard interfaces and then the rc script that simply drives that in an obvious way. The last objection I heard was that there's too much state to pass around, but it's not at all clear why unless this is trying to mix way too much rc.conf configuration in with wg config.

OK for the man page change. Make sure to bump the .Dd when you commit it for this content change.
Thanks for working on this, it's appreciated!