Page MenuHomeFreeBSD
People tuexen

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (431 w, 3 d)

Recent Activity
View All

Sat, May 11

tuexen closed D45122: tcp rack: do not send a challenge ack in the front stages.
Sat, May 11, 2:35 PM
tuexen committed rG2f923a0cedb8: tcp rack: improve handling of front states (authored by tuexen).
tcp rack: improve handling of front states
Sat, May 11, 2:35 PM

Fri, May 10

tuexen closed D45107: sctp: fix heartbeat timer.

Committed in 5120ea0d8871.

Fri, May 10, 8:24 PM
tuexen added a comment to D45107: sctp: fix heartbeat timer.
In D45107#1029978, @albin.hellqvist_ericsson.com wrote:

Nice!

Fri, May 10, 8:24 PM
tuexen committed rG5120ea0d8871: sctp: improve heartbeat timer computation (authored by tuexen).
sctp: improve heartbeat timer computation
Fri, May 10, 8:20 PM
tuexen accepted D45107: sctp: fix heartbeat timer.
Fri, May 10, 8:16 PM
tuexen committed rGb67716dd58b9: sctp: store heartbeat creation time as time_t (authored by tuexen).
sctp: store heartbeat creation time as time_t
Fri, May 10, 7:59 PM
tuexen committed rG42aeb8d490fb: sctp: store vtag expire time as time_t (authored by tuexen).
sctp: store vtag expire time as time_t
Fri, May 10, 7:46 PM
tuexen committed rG9d8a3718e24c: sctp: store cookie secret change time as time_t (authored by tuexen).
sctp: store cookie secret change time as time_t
Fri, May 10, 7:31 PM
tuexen accepted D45147: sockstat: Fix segfault when peer has no pid.
Fri, May 10, 6:12 PM
tuexen added inline comments to D45107: sctp: fix heartbeat timer.
Fri, May 10, 10:05 AM
tuexen updated the diff for D45107: sctp: fix heartbeat timer.

Fix computation of jitter.

Fri, May 10, 10:05 AM

Thu, May 9

tuexen committed rG0d15140d6d34: sctp: minor cleanup (authored by tuexen).
sctp: minor cleanup
Thu, May 9, 3:56 PM
tuexen committed rG8c37094036a5: sctp: allow stcb == NULL in sctp_shutdown() (authored by tuexen).
sctp: allow stcb == NULL in sctp_shutdown()
Thu, May 9, 3:49 PM
tuexen committed rG83dcc7790b11: sctp: don't provide uninitialized memory to process_chunk_drop() (authored by tuexen).
sctp: don't provide uninitialized memory to process_chunk_drop()
Thu, May 9, 3:24 PM
tuexen committed rGe187fa569047: sctp: fix sctp_sendall() when an mbuf chain is provided (authored by tuexen).
sctp: fix sctp_sendall() when an mbuf chain is provided
Thu, May 9, 2:50 PM
tuexen committed rG3d40cc7ab888: sctp: add missing check (authored by tuexen).
sctp: add missing check
Thu, May 9, 2:08 PM

Wed, May 8

tuexen requested review of D45122: tcp rack: do not send a challenge ack in the front stages.
Wed, May 8, 1:19 PM

Tue, May 7

tuexen accepted D45068: tcp: add sysctl to allow/disallow TSO during SACK loss recovery.
Tue, May 7, 5:58 PM
tuexen accepted D45070: tcp: add counter to track when SACK loss recovery uses TSO.
Tue, May 7, 5:58 PM
tuexen accepted D45075: tcp: filter small SACK blocks.
Tue, May 7, 5:55 PM
tuexen accepted D45076: tcp: clean up macro useage in tcp_fixed_maxseg().
Tue, May 7, 4:54 PM

Mon, May 6

tuexen requested review of D45107: sctp: fix heartbeat timer.
Mon, May 6, 8:49 PM

Fri, May 3

tuexen updated the summary of D44903: TCP can be subject to Sack Attacks lets fix this issue..
Fri, May 3, 1:44 PM
tuexen added inline comments to D44903: TCP can be subject to Sack Attacks lets fix this issue..
Fri, May 3, 1:26 PM
tuexen added a comment to D45075: tcp: filter small SACK blocks.

I'm wondering if it would be better to require that the sack block covers at least mss - 40. We don't know if we sent a SACK or AccECN option and it doesn't make sense to ignore the SACK blocks corresponding to such packets we sent not performing an attack.

Fri, May 3, 1:19 PM

Thu, May 2

tuexen committed rGeee88ef45f78: sctp: document sctp_recvmsg as implemented (authored by tuexen).
sctp: document sctp_recvmsg as implemented
Thu, May 2, 1:20 PM
tuexen accepted D45033: in_pcb: don't leak credential refcounts on error.
Thu, May 2, 5:34 AM

Wed, May 1

tuexen accepted D45033: in_pcb: don't leak credential refcounts on error.
Wed, May 1, 7:13 PM

Thu, Apr 25

tuexen added inline comments to D44928: sockets: hide socket hhook(9)s under SOCKET_HHOOK.
Thu, Apr 25, 5:27 AM

Wed, Apr 24

tuexen added a comment to D44420: Optimize HPTS so that little work is done until we have a hpts thread that is over the connection threshold.
In D44420#1024366, @zarychtam_plan-b.pwste.edu.pl wrote:

Is it worth MFC to stable/14 before releng/14.1 gets branched?

Wed, Apr 24, 8:48 PM
tuexen committed rG7fdef9cdb7ee: Optimize HPTS so that little work is done until we have a hpts thread that is… (authored by rrs).
Optimize HPTS so that little work is done until we have a hpts thread that is…
Wed, Apr 24, 8:42 PM
tuexen committed rG917b5431453d: HTPS has actually three states not two so the macro needs to account for that. (authored by rrs).
HTPS has actually three states not two so the macro needs to account for that.
Wed, Apr 24, 8:38 PM
tuexen committed rGd48e7e89e02f: TCP: Fix a rack bug that skyzall found which results in a crash. (authored by rrs).
TCP: Fix a rack bug that skyzall found which results in a crash.
Wed, Apr 24, 8:31 PM
tuexen added a comment to D44928: sockets: hide socket hhook(9)s under SOCKET_HHOOK.
In D44928#1024394, @stevek wrote:
In D44928#1024386, @glebius wrote:

Or, this can go under SOCKET_HHOOK new option. Cause these two hhooks aren't really related. What do you think?

I think SOCKET_HHOOK would be better, yes.

Wed, Apr 24, 8:00 PM

Sun, Apr 21

tuexen requested changes to D44889: tcp_bbr.4: Add a deprecation notice.

The decision is to keep BBR. See https://wiki.freebsd.org/TransportProtocols/18April2024.

Sun, Apr 21, 9:52 AM

Fri, Apr 19

tuexen abandoned D42084: Improve handling of detached inps.
Fri, Apr 19, 4:56 PM
tuexen closed D44746: tcp: drop data received after a FIN has been processed.

Committed in c9cd686bd4a0.

Fri, Apr 19, 4:55 PM

Thu, Apr 18

tuexen closed D44648: tcp rack: improve BBR_LOG_CWND event.
Thu, Apr 18, 8:28 PM
tuexen committed rG1941914d3bb4: tcp rack: improve BBR_LOG_CWND event (authored by tuexen).
tcp rack: improve BBR_LOG_CWND event
Thu, Apr 18, 8:28 PM
tuexen committed rGc9cd686bd4a0: tcp: drop data received after a FIN has been processed (authored by tuexen).
tcp: drop data received after a FIN has been processed
Thu, Apr 18, 8:22 PM

Wed, Apr 17

tuexen committed rG994f9c9e3c2c: tcp rack: fix sending (authored by tuexen).
tcp rack: fix sending
Wed, Apr 17, 2:20 PM
tuexen added a reverting change for rGb5ee7411bfab: tcp rack: fix sending: rG134884436681: Revert "tcp rack: fix sending".
Wed, Apr 17, 2:17 PM
tuexen committed rG134884436681: Revert "tcp rack: fix sending" (authored by tuexen).
Revert "tcp rack: fix sending"
Wed, Apr 17, 2:17 PM
tuexen added a reverting change for D44610: tcp rack: fix sending : rG134884436681: Revert "tcp rack: fix sending".
Wed, Apr 17, 2:17 PM
tuexen committed rGb5ee7411bfab: tcp rack: fix sending (authored by tuexen).
tcp rack: fix sending
Wed, Apr 17, 2:16 PM
tuexen committed rG14d778433227: tcp bbr: improve code consistency (authored by tuexen).
tcp bbr: improve code consistency
Wed, Apr 17, 2:03 PM
tuexen committed rG5344772af985: tcp: add some debug output (authored by tuexen).
tcp: add some debug output
Wed, Apr 17, 2:02 PM
tuexen committed rG90cde57af8c6: tcp: improve consistency (authored by tuexen).
tcp: improve consistency
Wed, Apr 17, 2:01 PM
tuexen committed rGc6770e8c99ab: tcp rack: fix memory corruption (authored by tuexen).
tcp rack: fix memory corruption
Wed, Apr 17, 2:00 PM
tuexen committed rG7a019565ff6d: uipc_socket: handle socket buffer locks in sopeeloff (authored by tuexen).
uipc_socket: handle socket buffer locks in sopeeloff
Wed, Apr 17, 1:59 PM
tuexen committed rG6572d12cfc67: tcp bblog: cleanup (authored by tuexen).
tcp bblog: cleanup
Wed, Apr 17, 1:56 PM
tuexen committed rG60898a7cef0b: tcp hpts: initialize variable (authored by tuexen).
tcp hpts: initialize variable
Wed, Apr 17, 1:56 PM
tuexen committed rGf3e2beb306c6: tcp: address a warning (authored by tuexen).
tcp: address a warning
Wed, Apr 17, 1:55 PM
tuexen committed rG7ebfafa813ce: tcp: fix conversion of rttvar (authored by tuexen).
tcp: fix conversion of rttvar
Wed, Apr 17, 1:55 PM
tuexen committed rGbe30b22fbb77: tcp: fix comment (authored by tuexen).
tcp: fix comment
Wed, Apr 17, 1:53 PM
tuexen committed rG8375db082c6b: tcp hpts: improve consistency (authored by tuexen).
tcp hpts: improve consistency
Wed, Apr 17, 1:52 PM
tuexen committed rGfbc8dfd0ed80: tcp bblog: use correct length (authored by tuexen).
tcp bblog: use correct length
Wed, Apr 17, 1:51 PM
tuexen committed rGfd2a580db248: tcp: no data on SYN segments unless doing TFO (authored by tuexen).
tcp: no data on SYN segments unless doing TFO
Wed, Apr 17, 1:50 PM
tuexen committed rGd69099e4330e: TCP LRO: add dtrace probe points (authored by tuexen).
TCP LRO: add dtrace probe points
Wed, Apr 17, 1:49 PM
tuexen committed rG8244b35ff88c: TCP LRO: disable mbuf queuing when packet filter hooks are in place (authored by tuexen).
TCP LRO: disable mbuf queuing when packet filter hooks are in place
Wed, Apr 17, 1:49 PM
tuexen committed rGbe7586fe468f: sctp: improve sending of packets containing an INIT ACK chunk (authored by tuexen).
sctp: improve sending of packets containing an INIT ACK chunk
Wed, Apr 17, 1:48 PM
tuexen committed rG49557689bf1e: sctp: improve consistency (authored by tuexen).
sctp: improve consistency
Wed, Apr 17, 1:47 PM
tuexen committed rGc5e78e553c66: dtrace: allow NULL interface pointer for ifinfo_t translator (authored by tuexen).
dtrace: allow NULL interface pointer for ifinfo_t translator
Wed, Apr 17, 1:47 PM
tuexen committed rG8b2c694d3836: RACK, BBR: handle EACCES like EPERM for IP output handling (authored by tuexen).
RACK, BBR: handle EACCES like EPERM for IP output handling
Wed, Apr 17, 1:46 PM
tuexen committed rG307daa4f1759: vnic: fix compilation of an IPv6 only kernel (authored by tuexen).
vnic: fix compilation of an IPv6 only kernel
Wed, Apr 17, 1:44 PM
tuexen committed rG2da45e304dba: TCP LRO: convert TCP header fields to host byte order earlier (authored by tuexen).
TCP LRO: convert TCP header fields to host byte order earlier
Wed, Apr 17, 1:43 PM

Mon, Apr 15

tuexen closed D44800: tcp bbr: improve code consistency.
Mon, Apr 15, 9:54 PM
tuexen committed rG605a00660ead: tcp bbr: improve code consistency (authored by tuexen).
tcp bbr: improve code consistency
Mon, Apr 15, 9:54 PM
tuexen retitled D44800: tcp bbr: improve code consistency from tcp bbr: fix memory corruption to tcp bbr: improve code consistency.
Mon, Apr 15, 8:10 PM
tuexen updated the diff for D44800: tcp bbr: improve code consistency.

Remove initialisation, which is not needed anymore.

Mon, Apr 15, 8:10 PM
tuexen requested review of D44800: tcp bbr: improve code consistency.
Mon, Apr 15, 8:01 PM
tuexen added a comment to D44746: tcp: drop data received after a FIN has been processed.
In D44746#1019858, @tuexen wrote:
In D44746#1019854, @gbe wrote:

Should BBR not also be affected by this change?

Possibly. But BBR is not kept in sync, it is more deprecated...

Mon, Apr 15, 10:50 AM
tuexen updated the diff for D44746: tcp: drop data received after a FIN has been processed.

Same fix for the BBR stack.

Mon, Apr 15, 10:49 AM

Apr 12 2024

tuexen added a comment to D44746: tcp: drop data received after a FIN has been processed.
In D44746#1019926, @gbe wrote:
In D44746#1019858, @tuexen wrote:
In D44746#1019854, @gbe wrote:

Should BBR not also be affected by this change?

Possibly. But BBR is not kept in sync, it is more deprecated...

As the author the manual pages for both tcp_rack(4) and tcp_bbr(4), should I update the bbr man page and add a deprecation notice somehow?

Since 14.1-RELEASE is approaching, it would be good to have updated documentation, or a complete removal of BBR in place.

Apr 12 2024, 8:41 AM

Apr 11 2024

tuexen added a comment to D44746: tcp: drop data received after a FIN has been processed.
In D44746#1019854, @gbe wrote:

Should BBR not also be affected by this change?

Apr 11 2024, 8:54 AM

Apr 10 2024

tuexen requested review of D44746: tcp: drop data received after a FIN has been processed.
Apr 10 2024, 10:30 PM
tuexen accepted D44734: Create little-endian hints files on all architectures.

I tested this patch on a BE system, the hints file is written in LE and can be used without problems.
I personally would commit the optimization (where there is not functional change intended) separately
from the change of the byte ordering of the hints file.

Apr 10 2024, 2:33 PM
tuexen added a comment to D44734: Create little-endian hints files on all architectures.

I'll test the patch on a BE system and report back.

Apr 10 2024, 8:50 AM

Apr 7 2024

tuexen committed rGe8c149ab85c7: tcp: add some debug output (authored by tuexen).
tcp: add some debug output
Apr 7 2024, 8:46 PM
tuexen closed D44669: tcp: add some debug output.
Apr 7 2024, 8:46 PM
tuexen requested review of D44669: tcp: add some debug output.
Apr 7 2024, 11:30 AM

Apr 6 2024

tuexen requested review of D44648: tcp rack: improve BBR_LOG_CWND event.
Apr 6 2024, 8:16 AM
tuexen closed D44645: tcp: improve consistency.
Apr 6 2024, 8:06 AM
tuexen committed rG3e1c8a35f741: tcp: improve consistency (authored by tuexen).
tcp: improve consistency
Apr 6 2024, 8:06 AM
tuexen closed D44647: tcp rack: fix memory corruption.
Apr 6 2024, 8:02 AM
tuexen committed rGd902c8f55b8d: tcp rack: fix memory corruption (authored by tuexen).
tcp rack: fix memory corruption
Apr 6 2024, 8:02 AM

Apr 5 2024

tuexen requested review of D44647: tcp rack: fix memory corruption.
Apr 5 2024, 8:22 PM
tuexen requested review of D44645: tcp: improve consistency.
Apr 5 2024, 5:56 PM
tuexen committed rG681711b77cde: uipc_socket: handle socket buffer locks in sopeeloff (authored by tuexen).
uipc_socket: handle socket buffer locks in sopeeloff
Apr 5 2024, 4:23 PM
tuexen closed D44640: uipc_socket: handle socket buffer locks in sopeeloff.
Apr 5 2024, 4:23 PM
tuexen committed rG7df0ef5f48e1: tcp rack: fix sending (authored by tuexen).
tcp rack: fix sending
Apr 5 2024, 3:51 PM
tuexen closed D44610: tcp rack: fix sending .
Apr 5 2024, 3:51 PM
tuexen committed rG60bc195745b8: tcp bblog: cleanup (authored by tuexen).
tcp bblog: cleanup
Apr 5 2024, 3:41 PM
tuexen closed D44616: tcp bblog: cleanup.
Apr 5 2024, 3:41 PM
tuexen retitled D44616: tcp bblog: cleanup from tcp hpts: cleanup to tcp bblog: cleanup.
Apr 5 2024, 3:36 PM
tuexen committed rGaaaa01c0c858: tcp hpts: initialize variable (authored by tuexen).
tcp hpts: initialize variable
Apr 5 2024, 3:35 PM
tuexen closed D44584: tcp hpts: initialize variable.
Apr 5 2024, 3:34 PM
tuexen added a comment to D44640: uipc_socket: handle socket buffer locks in sopeeloff.
In D44640#1017811, @markj wrote:

Can we please add some basic SCTP regression tests to the tree to help catch problems like this in the future?

Apr 5 2024, 2:24 PM

Apr 4 2024

tuexen requested review of D44640: uipc_socket: handle socket buffer locks in sopeeloff.
Apr 4 2024, 9:28 PM