Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 13165 Build 13411: arc lint + arc unit
Event Timeline
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
---|---|---|
3631 | Mmm, I don't know, there is already a link in the USE_PYTHON=flavors entry. |
I'd wait until the other two reviewers had time to review. I myself don't have anything else. Thanks for the work on this!
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
---|---|---|
3631 | Ah, OK. That's fine then. |
en_US.ISO8859-1/books/porters-handbook/flavors/chapter.xml | ||
---|---|---|
31 | I'd reinforce this: To distinguish flavors from options, which are always uppercase letters, f[lavor names can <emphasis>only</emphasis> contain...] | |
94–104 | I agree. I'd simplify it like this: To guard against <varname>FLAVOR</varname> being empty, which would cause a &man.make.1 error, use <literal>${FLAVOR:U}</literal> in string comparisons instead of <literal>${FLAVOR}</literal>. | |
145 | Add "the" To make the <filename>Makefile</filename> | |
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
3666 | s/one/version/ |
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
---|---|---|
3666 | And s/have//. |
en_US.ISO8859-1/books/porters-handbook/flavors/chapter.xml | ||
---|---|---|
18 | This is redundant. <emphasis>Flavors</emphasis> provide a way to have more than one variation of a port installed at the same time. | |
19 | port can have a normal version with standard options, and a <quote>lite</quote> version with fewer options and features so it is smaller in size. Is this a good example? I mean, it seems like the typical use of flavors is to have more than one variant of a port installed at the same time. Like having (sigh) py27-setuptools, py34-setuptools, and py36-setuptools. | |
23 | I would not make Flavors all uppercase here. The title is about using the feature, not the make variable. I think. If it really is about the make variable, be explicit about that: <title>Using the <varname>FLAVORS</varname> Variable</title> | |
31 | Good, but flip it so the restrictions are first and then the reason. <para>Flavor names are <emphasis>only</emphasis> allowed to contain | |
33 | <literal>_</literal>. This makes them visibly different from the values for options, which are upper case only.</para> | |
94–104 | FLAVOR must have a defined value before flavor-specific processing can start. Using the <literal>:U</literal> &man.make.1; feature simplifies this. If the variable is empty, the value it is compared to is assigned to it. (I'm not certain if this is a correct explanation.) | |
en_US.ISO8859-1/books/porters-handbook/order/chapter.xml | ||
381 | s/with/by/ | |
382 | Not sure if Flavors needs to be capitalized here. I would also move the <xref to the next line so that the whole tag is on one line: Continue with the possible flavors helpers. See <xref linkend="flavors-using"/> for more information.</para> | |
383 | And I'm positive that Information should not be capitalized here. | |
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
3630 | defined. It also implies | |
3668 | s/Only/This is only/ | |
3732 | Typo: s/conditionnal/conditional/ | |
3739 | Typo: s/conditionnal/conditional/ | |
3746 | Typo: s/conditionnal/conditional/ | |
3753 | Typo: s/conditionnal/conditional/ | |
3760 | Typo: s/conditionnal/conditional/ |