Page MenuHomeFreeBSD
Differential D12142

Don't start grouptaskqueue threads for unused grouptaskqueues
AcceptedPublic
Actions

Authored by kmacy on Aug 28 2017, 2:19 AM.
Tags
None
Referenced Files
F85100062: D12142.diff
Sat, Jun 1, 3:58 PM
Unknown Object (File)
Mon, May 27, 12:55 PM
Unknown Object (File)
Thu, May 9, 11:43 PM
Unknown Object (File)
Thu, May 9, 7:08 PM
Unknown Object (File)
Thu, May 9, 8:12 AM
Unknown Object (File)
Apr 28 2024, 1:23 PM
Unknown Object (File)
Apr 26 2024, 5:04 PM
Unknown Object (File)
Apr 25 2024, 12:14 AM
View All 33 Files
Subscribers
ae
imp
kbowling
krzysztof.galazka_intel.com

Details

Reviewers
shurd
scottl
sbruno
jtl
glebius
erj
Group Reviewers
Intel Networking
Summary

Defer starting grouptaskqueue threads until the first time a grouptask is associated with the group.

This keeps iflib from cluttering ddb ps when there are no iflib drivers in the system.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 11273

Event Timeline

kmacy created this revision.Aug 28 2017, 2:19 AM
Herald added subscribers: ae, imp. · View Herald TranscriptAug 28 2017, 2:19 AM
kmacy added a subscriber: kbowling.Aug 28 2017, 2:19 AM
kbowling added a reviewer: glebius.Aug 28 2017, 6:57 AM
kmacy updated this revision to Diff 32467.Aug 29 2017, 12:41 AM

Only launch as many threads as we actually need
@sbruno dedicated branch vs iflib/ithread_dispatch called iflib/pollution reduction

shurd accepted this revision.Sep 5 2017, 12:29 AM

Looks good to me.

This revision is now accepted and ready to land.Sep 5 2017, 12:29 AM
shurd mentioned this in D12235: iflib rollup patch..Sep 5 2017, 9:15 PM
shurd mentioned this in D12446: Support attaching tx queues to cpus.Sep 23 2017, 1:03 AM
krzysztof.galazka_intel.com added a reviewer: Intel Networking.Nov 30 2017, 6:20 PM
krzysztof.galazka_intel.com added a subscriber: krzysztof.galazka_intel.com.
kmacy added a comment.May 3 2018, 4:09 AM

@shurd does this still work or should it be abandoned?

shurd added a comment.May 3 2018, 5:11 PM

May as well abandon it until/unless there's interest. I don't think there's much gain for the added complexity.

erj resigned from this revision.Oct 3 2018, 5:21 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
87 lines
net/
79 lines
sys/
27 lines

Diff 32467

View Options

sys/kern/subr_gtaskqueue.c

Loading...
View Options

sys/net/iflib.c

Loading...
View Options

sys/sys/gtaskqueue.h

Loading...