Details

Reviewers

acm
antoine
ashish
bofh
danfe
eduardo
ehaupt
eugen_grosbein.net
henry.hu.sh_gmail.com
jbeich
jwb
khng
martymac
monwarez_mailoo.org
nc
nobutaka
pi
pkubaj
sunpoet
tagattie
tijl
vanilla
yuri
zi
arrowd

Group Reviewers

Erlang
gnome
portmgr
kde
multimedia
vbox

Summary

While here simplify logic for superseded compiler default versions.

Test Plan

make INDEX

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 57640
Build 54528: arc lint + arc unit

Event Timeline

rene requested review of this revision.Thu, May 9, 5:16 PM

rene created this revision.

Harbormaster completed remote builds in B57639: Diff 138306.Thu, May 9, 5:16 PM

mat added a subscriber: mat.Thu, May 9, 5:22 PM

mat added inline comments.

Mk/bsd.port.mk
45	Maybe pick a version further in the future, say, 1501000, so that it does not have to be updated that much ?

rene added reviewers: acm, antoine, ashish, bofh, danfe, eduardo, ehaupt, Erlang, eugen_grosbein.net, gnome, portmgr, henry.hu.sh_gmail.com, jbeich, jwb, kde, khng, martymac, monwarez_mailoo.org, multimedia, nc, nobutaka, pi, pkubaj, sunpoet, tagattie, tijl, vanilla, vbox, yuri, zi.Thu, May 9, 5:31 PM

rene added inline comments.

Mk/bsd.port.mk
45	Fair enough

Mk/bsd.port.mk: move an example FreeBSD version more into the future

Harbormaster completed remote builds in B57640: Diff 138307.Thu, May 9, 5:35 PM

rene marked an inline comment as done.Thu, May 9, 5:36 PM

Skimmed through all changes, but didn't run-test.

This revision is now accepted and ready to land.Thu, May 9, 5:38 PM

yuri accepted this revision.Thu, May 9, 5:42 PM

Can you also drop annotated cruft?

$ git grep -lF 'FreeBSD 13.2 EOL'
devel/hyprlang/Makefile
emulators/rpcs3/Makefile
emulators/yuzu/Makefile
x11/hyprcursor/Makefile
x11/hyprlock/Makefile
x11/xdg-desktop-portal-hyprland/Makefile
x11-toolkits/como/Makefile
x11-wm/gamescope/Makefile
x11-wm/hyprland/Makefile
x11-wm/theseus-ship/Makefile

graphics/nvidia-drm-510-kmod/Makefile
15	Do you plan to remove the actual file as well?

eduardo accepted this revision.Thu, May 9, 7:29 PM

cleanup: remove more EOL FreeBSD 13.2 code

This revision now requires review to proceed.Thu, May 9, 7:51 PM

Harbormaster completed remote builds in B57645: Diff 138320.Thu, May 9, 7:51 PM

Incorporated suggestions from @jbeich , updated TIMESTAMPs of affected distinfo files.

monwarez_mailoo.org accepted this revision.Fri, May 10, 9:03 AM

This revision is now accepted and ready to land.Fri, May 10, 9:03 AM

audio/ocp looks good.

nobutaka accepted this revision.Fri, May 10, 4:29 PM

editors/kakoune need to be skipped, as I recently updated it, and removed those lines, and so the editors/kakoune/Makefile part of this patch isn't applicable anymore.

Thanks!

This revision now requires changes to proceed.Fri, May 10, 8:48 PM

Rebase, drop obsoleted patch for editors/kakoune

Harbormaster completed remote builds in B57665: Diff 138399.Sat, May 11, 10:31 AM

ashish accepted this revision.Sat, May 11, 2:26 PM

This revision is now accepted and ready to land.Sat, May 11, 2:26 PM

acm accepted this revision.Sat, May 11, 4:47 PM

Changes to games/flightgear look good to me. Thanks!

The changes for devel/electron* look good. Thanks for taking care of those ports.

monwarez_mailoo.org accepted this revision.Mon, May 20, 9:20 AM

rebase

This revision now requires review to proceed.Thu, May 23, 8:07 PM

Harbormaster completed remote builds in B57883: Diff 139012.Thu, May 23, 8:07 PM

vvd added a subscriber: vvd.Thu, May 23, 8:31 PM

vvd added inline comments.

emulators/virtualbox-ose-legacy/Makefile
199	I think we can remove this line too - it's old 14-CURRENT before create stable/14.

vvd added inline comments.Thu, May 23, 8:35 PM

emulators/virtualbox-ose-legacy/Makefile
200	We must remove this too. 13.3 is affected too and require LLVM 15 for build this version of the VirtualBox.

rene added inline comments.Sat, May 25, 10:47 AM

emulators/virtualbox-ose-legacy/Makefile
199	Probably cleaner to remove it with 14.0-EOL ?
200	From the comment in the Makefile it looks like a ${OSVERSION} > 1303000 must be added instead?

vvd added inline comments.Sat, May 25, 1:18 PM

emulators/virtualbox-ose-legacy/Makefile
199	It isn't 14.0 - it's 14-CURRENT. 14-CURRENT is EOL since 14.0 released, isn't it?
200	There is work for build it with LLVM from base: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279257

rene added inline comments.Sat, May 25, 1:56 PM

emulators/virtualbox-ose-legacy/Makefile
200	It looks like a separate issue from dropping 13.2

rebase

Harbormaster completed remote builds in B57953: Diff 139193.Wed, May 29, 5:04 PM

No objections for ports I maintain.

This revision is now accepted and ready to land.Wed, May 29, 7:43 PM

LGTM. Thank you, @rene.

cleanup: remove support for EOL FreeBSD 13.2AcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 138307

Mk/bsd.port.mk

audio/audacity/Makefile

audio/audacity/files/extra-libraries_lib-utility_TypeList.h

audio/audacity/files/extra-libraries_lib-utility_TypeList.cpp

audio/audacity/files/extra-libraries_lib-utility_TypeSwitch.h

audio/denemo/Makefile

audio/ncmpc/Makefile

audio/ocp/Makefile

audio/openal-soft/Makefile

biology/py-macs3/Makefile

chinese/libime/Makefile

databases/arrow/Makefile

databases/xtrabackup80/Makefile

databases/xtrabackup81/Makefile

deskutils/kdepim-runtime/Makefile

devel/cjose/Makefile

devel/corrade/Makefile

devel/electron25/Makefile

devel/electron27/Makefile

devel/electron28/Makefile

devel/electron28/files/extra-patch-electron_shell_browser_electron__browser__context.h

devel/electron28/files/extra-patch-electron_shell_browser_ui_gtk_menu__gtk.h

devel/electron28/files/extra-patch-electron_shell_browser_ui_status__icon__gtk.h

devel/electron29/Makefile

devel/electron29/files/extra-patch-electron_shell_browser_electron__browser__context.h

devel/electron29/files/extra-patch-electron_shell_browser_ui_gtk_menu__gtk.h

devel/electron29/files/extra-patch-electron_shell_browser_ui_status__icon__gtk.h

devel/ptlib/Makefile

devel/py-threadpoolctl/Makefile

devel/qjson/Makefile

devel/spirv-llvm-translator/Makefile

devel/tcl-trf/Makefile

devel/tex-libtexluajit/Makefile

devel/ucommon/Makefile

dns/getdns/Makefile

editors/calligra/Makefile

editors/e93/Makefile

editors/imhex-current/Makefile

editors/kakoune/Makefile

editors/libreoffice/Makefile

editors/zile/Makefile

emulators/citra/Makefile

emulators/fs-uae/Makefile

emulators/virtualbox-ose-legacy/Makefile

games/alienarena/Makefile

games/assaultcube/Makefile

games/chessx/Makefile

games/flightgear/Makefile

games/libretro-bluemsx/Makefile

games/libretro-pcsx_rearmed/Makefile

games/megaglest/Makefile

games/openclonk/Makefile

games/trigger-rally/Makefile

graphics/dcmtk/Makefile

graphics/nvidia-drm-510-kmod/Makefile

java/eclipse/Makefile

java/openjdk11/Makefile

java/openjdk17/Makefile

java/openjdk18/Makefile

java/openjdk19/Makefile

java/openjdk20/Makefile

java/openjdk21/Makefile

java/openjdk22/Makefile

java/openjdk8/Makefile

lang/erlang-runtime21/Makefile

lang/erlang-runtime22/Makefile

lang/erlang-runtime23/Makefile

lang/erlang-runtime24/Makefile

lang/erlang-runtime25/Makefile

lang/erlang-runtime26/Makefile

lang/erlang/Makefile

lang/smlnj/Makefile

lang/spidermonkey102/Makefile

lang/spidermonkey78/Makefile

cleanup: remove support for EOL FreeBSD 13.2
AcceptedPublic
Actions

Revision Contents
Changeset List

devel/electron28/files/extra-patch-electron_shell_browser_electronbrowsercontext.h

devel/electron28/files/extra-patch-electron_shell_browser_ui_statusicongtk.h

devel/electron29/files/extra-patch-electron_shell_browser_electronbrowsercontext.h

devel/electron29/files/extra-patch-electron_shell_browser_ui_statusicongtk.h