Page MenuHomeFreeBSD

libcrypto, libssl: link .so's with -Bsymbolic for upstream parity
Needs ReviewPublic

Authored by ngie on Apr 21 2024, 5:44 PM.
Tags
None
Referenced Files
F85492126: D44894.diff
Thu, Jun 6, 6:30 PM
Unknown Object (File)
Mon, May 20, 4:01 PM
Unknown Object (File)
Tue, May 14, 7:10 AM
Unknown Object (File)
May 2 2024, 4:07 PM
Unknown Object (File)
Apr 30 2024, 2:48 PM
Unknown Object (File)
Apr 27 2024, 6:04 PM
Unknown Object (File)
Apr 27 2024, 3:30 AM
Unknown Object (File)
Apr 26 2024, 3:51 PM
Subscribers

Details

Reviewers
cy
emaste
Summary

This change modifies libcrypto, libssl, and dependent .so files to use
-Wl,-Bsymbolic to prefer locally defined symbols over globally defined
symbols in order to have parity with the upstream OpenSSL build process.

Test Plan

TODO: run tinderbox build

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57263
Build 54151: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Apr 21 2024, 5:44 PM
ngie added reviewers: cy, emaste.

-Wl,-Bsymbolic should be added to SOLINKOPTS instead of LDFLAGS

This avoids breaking the static object build case.