Differential D43860

reboot: Use posix_spawn instead of system
ClosedPublic
Actions

Authored by imp on Feb 13 2024, 4:50 AM.

Details

Reviewers

jrtc27

Commits

rG33a2406eed00: reboot: Use posix_spawn instead of system

Summary

Use posix_spawn to avoid having to allocate memory needed for the system
command line.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56017
Build 52906: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 13 2024, 4:50 AM

imp created this revision.

Herald added a subscriber: cy. · View Herald TranscriptFeb 13 2024, 4:50 AM

Harbormaster completed remote builds in B55980: Diff 134238.Feb 13 2024, 4:50 AM

imp added a reviewer: jrtc27.Feb 13 2024, 4:51 AM

jrtc27 added inline comments.Feb 13 2024, 6:55 PM

sbin/reboot/reboot.c
76	Shouldn't there only be one copy?
94–110	Check return value? Especially for EINTR.
104–106	Would seem more natural to flip these two cases?

imp added inline comments.Feb 14 2024, 8:58 PM

sbin/reboot/reboot.c
76	Oh, yes.
94–110	Should we look on EINTR? Or just ignore it?
104–106	sure.

Update per reviews

Harbormaster completed remote builds in B56017: Diff 134344.Feb 14 2024, 9:01 PM

imp added a child revision: D43900: loader: Register the gfx stuff separately..Feb 14 2024, 9:55 PM

jrtc27 accepted this revision.Feb 15 2024, 11:17 PM

This revision is now accepted and ready to land.Feb 15 2024, 11:17 PM

Closed by commit rG33a2406eed00: reboot: Use posix_spawn instead of system (authored by imp). · Explain WhyFeb 16 2024, 4:00 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG33a2406eed00: reboot: Use posix_spawn instead of system.

Revision Contents
Changeset List

Path

Size

sbin/

reboot/

reboot.c

54 lines

Diff 134344

View Options

reboot: Use posix_spawn instead of systemClosedPublicActions