Page MenuHomeFreeBSD
Differential D43135

libifconfig: Fix bridge status member list
ClosedPublic
Actions

Authored by grembo on Dec 20 2023, 8:27 PM.
Tags
None
Referenced Files
F85216816: D43135.diff
Mon, Jun 3, 5:43 AM
Unknown Object (File)
Fri, May 31, 6:37 AM
Unknown Object (File)
Fri, May 31, 6:37 AM
Unknown Object (File)
Thu, May 9, 10:41 AM
Unknown Object (File)
Thu, May 9, 10:40 AM
Unknown Object (File)
Thu, May 9, 4:07 AM
Unknown Object (File)
Thu, May 9, 4:07 AM
Unknown Object (File)
Thu, May 9, 4:04 AM
View All 25 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
kp
Commits
rGe65182c7bc28: libifconfig: Fix bridge status member list
rGc2299997ce17: libifconfig: Fix bridge status member list
rG3d36053ca6d6: libifconfig: Fix bridge status member list
Summary

When this functionality was moved to libifconfig in 3dfbda3401abea84da9,
the end of list calculation was modified for unknown reasons, practically
limiting the number of bridge member returned to 102.

This patch changes the calculation back to what it was originally.

Test Plan

Create 200 epair interfaces and add them to bridge0, check
the number of members shown on ifconfig bridge0.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtests/sys/net/if_bridge_test.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 55053
Build 51942: arc lint + arc unit

Event Timeline

grembo created this revision.Dec 20 2023, 8:27 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 20 2023, 8:27 PM
grembo requested review of this revision.Dec 20 2023, 8:27 PM
Harbormaster completed remote builds in B55050: Diff 131615.Dec 20 2023, 8:27 PM
grembo added a reviewer: kp.Dec 20 2023, 8:29 PM
kp added a comment.Dec 20 2023, 8:33 PM

I'll try to review tomorrow.

Can I get you to add a test case for this to tests/sys/net/if_bridge_test.sh too?

grembo updated this revision to Diff 131617.Dec 20 2023, 9:17 PM

Add unit test

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptDec 20 2023, 9:17 PM
Harbormaster completed remote builds in B55052: Diff 131617.Dec 20 2023, 9:17 PM
grembo updated this revision to Diff 131618.Dec 20 2023, 9:18 PM

post merge clesanup

Harbormaster completed remote builds in B55053: Diff 131618.Dec 20 2023, 9:18 PM
grembo added a comment.Dec 20 2023, 9:19 PM

@kp here you go (lint error seems to be a false positive)

kp accepted this revision.Dec 21 2023, 2:52 PM
This revision is now accepted and ready to land.Dec 21 2023, 2:52 PM
This revision was landed with ongoing or failed builds.Dec 21 2023, 3:51 PM
Closed by commit rG3d36053ca6d6: libifconfig: Fix bridge status member list (authored by grembo). · Explain Why
This revision was automatically updated to reflect the committed changes.
grembo added a commit: rG3d36053ca6d6: libifconfig: Fix bridge status member list.
grembo added a comment.Dec 21 2023, 3:52 PM

@kp thanks for the review

grembo added a commit: rGc2299997ce17: libifconfig: Fix bridge status member list.Jan 5 2024, 11:58 AM
grembo added a commit: rGe65182c7bc28: libifconfig: Fix bridge status member list.Jan 28 2024, 5:57 PM

Revision Contents
Changeset List

PathSize
lib/
libifconfig/
2 lines
tests/
sys/
net/
28 lines

Diff 131618

View Options

lib/libifconfig/libifconfig_bridge.c

Loading...
View Options

tests/sys/net/if_bridge_test.sh

Loading...