pci: Fix pci_host_generic_acpi with gcc
ClosedPublic
Actions

Authored by andrew on Mon, May 20, 12:00 PM.

Details

Reviewers

brooks
imp
emaste
jhb

Group Reviewers

arm64

Commits

rGf55e866488ba: pci: Fix pci_host_generic_acpi with gcc

Summary

In pci_host_generic_acpi.c we loop over pci_acpi_quirks to check if
we need to handle any quirks. GCC doesn't like the terminatin as it
sets a fixed width string to 0.

As this the array is only ever used in this file change to use nitems
to find when to stop the loop.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew requested review of this revision.Mon, May 20, 12:00 PM

andrew created this revision.

andrew added a parent revision: D45264: arm64/rockchip: Fix the build with GCC.

andrew added a child revision: D45266: dev/hwpmc: Fix the dmc620 MD4 macro.

Harbormaster completed remote builds in B57779: Diff 138766.Mon, May 20, 12:01 PM

jhb accepted this revision.Mon, May 20, 5:25 PM

This revision is now accepted and ready to land.Mon, May 20, 5:25 PM

brooks accepted this revision.Mon, May 20, 6:23 PM

imp accepted this revision.Mon, May 20, 10:57 PM

emaste accepted this revision.Mon, May 20, 11:18 PM

Closed by commit rGf55e866488ba: pci: Fix pci_host_generic_acpi with gcc (authored by andrew). · Explain WhyWed, May 22, 8:34 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGf55e866488ba: pci: Fix pci_host_generic_acpi with gcc.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic_acpi.c

5 lines

Diff 138896

View Options

sys/dev/pci/pci_host_generic_acpi.c

pci: Fix pci_host_generic_acpi with gccClosedPublicActions