Page MenuHomeFreeBSD

libdiff: Add a test for the truncation issue.
ClosedPublic

Authored by des on Thu, May 16, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 3:11 AM
Unknown Object (File)
Wed, May 22, 4:55 AM
Unknown Object (File)
Mon, May 20, 2:10 PM
Unknown Object (File)
Sun, May 19, 2:12 AM
Unknown Object (File)
Sat, May 18, 6:44 PM
Unknown Object (File)
Sat, May 18, 3:16 PM
Unknown Object (File)
Sat, May 18, 6:57 AM
Unknown Object (File)
Fri, May 17, 7:21 PM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Thu, May 16, 12:26 PM
This revision is now accepted and ready to land.Thu, May 16, 1:40 PM
markj added inline comments.
lib/libdiff/tests/libdiff_test.c
36

You might consider using some multiple of the system page size instead. For instance, on arm64 it's possible to configure a base page size of 64KB, in which case this test is going to truncate within a page and so won't trigger SIGBUS.

55

In general you don't need to clean up files in the current directory, kyua or whatever other test runner should handle that for you I believe.

This revision was automatically updated to reflect the committed changes.