network.subr: Remove extraneous checkyesno synchronous_dhclient
AbandonedPublic
Actions

Authored by cy on Apr 25 2024, 7:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 3, 10:00 AM

	Unknown Object (File)
	Thu, May 23, 6:51 PM

	Unknown Object (File)
	Fri, May 10, 6:12 PM

	Unknown Object (File)
	Wed, May 8, 1:18 PM

	Unknown Object (File)
	May 5 2024, 8:21 PM

	Unknown Object (File)
	Apr 28 2024, 8:36 PM

	Unknown Object (File)
	Apr 26 2024, 7:30 PM

	Unknown Object (File)
	Apr 26 2024, 7:30 PM

View All 9 Files

Subscribers

None

Details

Reviewers

imp
bz

Summary

checkyesno outside of an if construct makes no sense.

Fixes: 5d595cb88eaa

Test Plan

Tested locally.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cy requested review of this revision.Apr 25 2024, 7:53 PM

cy created this revision.

cy added a reviewer: bz.Apr 25 2024, 7:57 PM

Why not? Is that not just passing the result back to the caller at the end of the shell function?
Given I have to ask this, I am probably not the right one to review...

In D44960#1024991, @bz wrote:

Why not? Is that not just passing the result back to the caller at the end of the shell function?
Given I have to ask this, I am probably not the right one to review...

That is indeed what it's doing.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

network.subr

2 lines

Diff 137691

View Options

network.subr: Remove extraneous checkyesno synchronous_dhclientAbandonedPublicActions