Page MenuHomeFreeBSD

wlan: update drivers to use ieee80211_set_hardware_ciphers()
Needs RevisionPublic

Authored by adrian on Thu, Apr 25, 4:08 AM.
Referenced Files
Unknown Object (File)
Wed, May 1, 5:07 PM
Unknown Object (File)
Tue, Apr 30, 8:15 PM
Unknown Object (File)
Sat, Apr 27, 5:43 PM
Unknown Object (File)
Fri, Apr 26, 5:20 PM
Unknown Object (File)
Fri, Apr 26, 2:06 PM
Unknown Object (File)
Fri, Apr 26, 2:06 PM
Unknown Object (File)
Fri, Apr 26, 12:13 PM
Unknown Object (File)
Fri, Apr 26, 8:26 AM
Subscribers

Details

Reviewers
cc
Group Reviewers
wireless
Summary

This migrates drivers to use ieee80211_set_hardware_ciphers() instead
of setting ic_cryptocaps directly.

The only driver that hasn't entirely had ic_cryptocaps access removed
is if_ath(4); it's doing something tricksy to work around a hardware
issue (it looks like TKIP + WME/QoS frames may be buggy or not
supported.) I'll need to think about this and address it in a future
commit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57341
Build 54229: arc lint + arc unit

Event Timeline

cc requested changes to this revision.Mon, May 13, 2:37 PM
cc added a subscriber: cc.

I see you made comments of "ieee80211_set_software_ciphers() is not needed" in if_rtwn.c. Do you mind to add it in the rest of the drivers files? Or is there any better/central place to put such comment or document it?

sys/dev/ath/if_ath.c
608

I would use hwcryptocaps instead, in case there will be swcryptocaps in the future, even if most drivers don't have software crypto. Also hwcryptocaps makes it clear that this is not software crypto caps. So saves comment.

I think this can also help to reduce the rename work once the member name ic_cryptocaps be renamed as ic_hw_cryptocaps later.

sys/dev/rtwn/if_rtwn.c
238–239

Do you mean this? As from ieee80211_crypto_attach() in 1116e8b95c60:

rtwn supports the default set of net80211 supported ciphers, no more no less,

This revision now requires changes to proceed.Mon, May 13, 2:37 PM