Differential D44860

ahc(4)/ahd(4): fix target mode on ARM
ClosedPublic
Actions

Authored by kevans on Fri, Apr 19, 2:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 6:36 PM

	Unknown Object (File)
	Sun, Apr 21, 6:00 PM

	Unknown Object (File)
	Sun, Apr 21, 4:10 AM

	Unknown Object (File)
	Sat, Apr 20, 6:31 PM

Subscribers

Details

Reviewers

imp
mav

Commits

rG9dcf39575efb: ahc(4)/ahd(4): fix target mode on ARM

Summary

One of the comments in ahc_execute_scb() notes that the CAM direction is
actually w.r.t. the initiator. As a consequence, all of our sync ops
end up being wrong because the direction is flipped from that of the
transfer. Fix it to do proper invalidation and avoid spewing random
garbage out on the SCSI bus.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans requested review of this revision.Fri, Apr 19, 2:05 AM

kevans created this revision.

kevans added a parent revision: D44859: ahc(4): resolve some minor nits.

Harbormaster completed remote builds in B57208: Diff 137373.Fri, Apr 19, 2:06 AM

imp accepted this revision.Fri, Apr 19, 2:11 AM

This revision is now accepted and ready to land.Fri, Apr 19, 2:11 AM

I have tested this on an Raspberry PI CM4 with the IO board and this works there.

Looks good to me, but if you wish, couple cosmetic thoughts.

sys/dev/aic7xxx/aic7xxx_osm.c
306	post asks to be bool, but considering age of the driver...
309	flags in struct ccb_hdr is uint32_t.

kevans marked 2 inline comments as done.Sun, Apr 21, 2:59 AM

Closed by commit rG9dcf39575efb: ahc(4)/ahd(4): fix target mode on ARM (authored by kevans). · Explain WhySun, Apr 21, 3:06 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG9dcf39575efb: ahc(4)/ahd(4): fix target mode on ARM.

Revision Contents
Changeset List

Path

Size

sys/

dev/

aic7xxx/

35 lines

35 lines

Diff 137451

sys/dev/aic7xxx/aic79xx_osm.c

Loading...

sys/dev/aic7xxx/aic7xxx_osm.c

Loading...