bsdinstall: implement timezone with bsddialog
Needs ReviewPublic
Actions

Authored by khorben_defora.org on Apr 7 2024, 5:31 PM.

Details

Reviewers

jrtc27
bapt
asiciliano

Summary

This effectively imports most of the timezone script from bsdconfig to bsdinstall. This allows:

invoking bsddialog(1) in line with bsdinstall(8)
keeping the backtitle consistent with that of the installer
eventually, direct support for graphical mode

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

khorben_defora.org created this revision.Apr 7 2024, 5:31 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2024, 5:31 PM

khorben_defora.org requested review of this revision.Apr 7 2024, 5:31 PM

Why do we need a copy of this code rather than just tweaking bsdconfig to support this?

In D44670#1018389, @jrtc27 wrote:

Why do we need a copy of this code rather than just tweaking bsdconfig to support this?

My initial changes drifted a lot more from the original code of bsdconfig, like replacing every occurence of $DIALOG_BACKTITLE with $OSNAME Installer. I have tried to minimize the changes to the bare minimum for this series of reviews, and to restrict the changes to usr.sbin/bsdinstall for clarity.

However I can look into creating a different version of this replacement of timezone with some tweaking in bsdconfig instead.

khorben_defora.org added a child revision: D45000: release: create a bootable image with the graphical installer.Mon, Apr 29, 12:35 AM