Page MenuHomeFreeBSD
Differential D44620

iflib: Fix compiler warnings
ClosedPublic
Actions

Authored by stevek on Apr 3 2024, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 2:18 AM
Unknown Object (File)
Tue, Apr 30, 9:24 AM
Unknown Object (File)
Fri, Apr 26, 6:10 AM
Unknown Object (File)
Fri, Apr 26, 4:43 AM
Unknown Object (File)
Apr 15 2024, 3:13 PM
Unknown Object (File)
Apr 8 2024, 12:11 PM
Unknown Object (File)
Apr 5 2024, 2:33 PM
Subscribers
ae
glebius
jeffpc_josefsipek.net
jhb
melifaro

Details

Reviewers
gallatin
erj
imp
shurd
jhb
Group Reviewers
iflib
Commits
rG303dea74c2cb: iflib: Fix compiler warnings
Summary

Some of the QUAD sysctls are actually for unsigned quad values.
Switch to using UQUAD instead, as that is meant for unsigned.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stevek created this revision.Apr 3 2024, 8:23 PM
Herald added a reviewer: shurd. · View Herald TranscriptApr 3 2024, 8:23 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: glebius, melifaro, ae. · View Herald Transcript
stevek requested review of this revision.Apr 3 2024, 8:23 PM
Harbormaster completed remote builds in B56897: Diff 136496.Apr 3 2024, 8:23 PM
jeffpc_josefsipek.net added a subscriber: jeffpc_josefsipek.net.Apr 12 2024, 2:01 PM
jeffpc_josefsipek.net added inline comments.
sys/net/iflib.c
6854

Should the wrapped lines be indented one more char to maintain alignment?

jhb added a subscriber: jhb.Apr 12 2024, 8:05 PM

LGTM. If the file was using normal style it wouldn't need the indentation fixup (which will add a lot of noise). I would maybe suggest instead to fix the indentation to not be unusual in lieu of the one char fixup.

erj accepted this revision.Apr 12 2024, 8:07 PM
This revision is now accepted and ready to land.Apr 12 2024, 8:07 PM
stevek added a comment.Apr 12 2024, 9:29 PM
In D44620#1020403, @jhb wrote:

LGTM. If the file was using normal style it wouldn't need the indentation fixup (which will add a lot of noise). I would maybe suggest instead to fix the indentation to not be unusual in lieu of the one char fixup.

What about committing this change as-is and then doing a follow-up to correct the style as a separate review?

jhb added a comment.Apr 12 2024, 10:53 PM
In D44620#1020418, @stevek wrote:
In D44620#1020403, @jhb wrote:

LGTM. If the file was using normal style it wouldn't need the indentation fixup (which will add a lot of noise). I would maybe suggest instead to fix the indentation to not be unusual in lieu of the one char fixup.

What about committing this change as-is and then doing a follow-up to correct the style as a separate review?

Yes, that's fine with me.

jhb accepted this revision.Apr 12 2024, 10:53 PM
Closed by commit rG303dea74c2cb: iflib: Fix compiler warnings (authored by stevek). · Explain WhyApr 15 2024, 2:58 PM
This revision was automatically updated to reflect the committed changes.
stevek added a commit: rG303dea74c2cb: iflib: Fix compiler warnings.
stevek mentioned this in D44811: iflib: Correct indentation according to style(9).Apr 16 2024, 8:17 PM

Revision Contents
Changeset List

PathSize
sys/
net/
30 lines

Diff 137049

View Options

sys/net/iflib.c

Loading...