Reference: http://manuals.opensound.com/developer/SNDCTL_SETNAME.html
Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Differential D44570
sound: Implement SNDCTL_SETNAME christos on Mar 31 2024, 5:14 AM. Authored by
Details
Reference: http://manuals.opensound.com/developer/SNDCTL_SETNAME.html Sponsored by: The FreeBSD Foundation
Diff Detail
Event Timeline
Comment Actions Do you have a particular interest in this ioctl? I didn't find any software using it on github, just example code from the 4Front OSS docs. Maybe it's a good opportunity to add an OSS API test executable now? Otherwise I have to hack it into sosso or something to run it. Also probably needs rebase, doesn't apply with git arc patch on main.
Comment Actions Address Mark's comments. NUL-terminate the input string in general, but also Comment Actions I really just want to implement them for completeness. There is no reason not to implement them, plus they are easy to implement.
I don't know if I will do it right now, but I am definitely planning on writing some kind of OSS API test suite/program in the near future.
I just applied it without problems. Do you still have this issue?
Comment Actions Hacked it into the sosso test executable to exercise this ioctl, I'm still not convinced of its utility. This lets every application of all users set the device description globally. I think it's useful on a system level (mixer or similar tool), but I'd be wary to use it in an application. For the purposes mentioned in OSSv4, something like virtual_oss can set the description of the pcm devices it creates in a different way.
Comment Actions As I said already, I also do not think these IOCTLs are actually important at least for now, but I wanted to implement them for completeness. However, I am not sure if it's a good allocation of resources, so maybe it's better to abandon these for now. |