Hyper-V: vPCI: limit 64 cpus for msi/msix interrupt handling on FreeBSD 13.x
ClosedPublic
Actions

Authored by whu on Mar 11 2024, 10:47 AM.

Details

Reviewers

kib
markj
imp
stallamr_netapp.com

Commits

rGe4b8828947b1: Hyper-V: vPCI: limit 64 cpus for msi/msix interrupt handling

Summary

On older Hyper-V vPCI protocol version 1.1, only the first 64 cpus are able to handle msi/msix. This is true on FreeBSD 13.x and earlier releases. If MSI IRQ is assigned to cpu id greater than 63, it would lead to missing interrupts. Add check in set_interrupt_apic_ids() to only add first 64 cpus into the interrupt cpu set.

This doesn't apply to FreeBSD 14 and later, which already have vPCI 1.4 support.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

whu requested review of this revision.Mar 11 2024, 10:47 AM

whu created this revision.

I suppose this is a direct commit to stable/13?

This revision is now accepted and ready to land.Mar 11 2024, 3:05 PM

Verified in NetApp lab.

In D44297#1010461, @kib wrote:

I suppose this is a direct commit to stable/13?

Yes, it is.

Closed by commit rGe4b8828947b1: Hyper-V: vPCI: limit 64 cpus for msi/msix interrupt handling (authored by whu). · Explain WhyMar 12 2024, 5:14 AM

This revision was automatically updated to reflect the committed changes.

whu added a commit: rGe4b8828947b1: Hyper-V: vPCI: limit 64 cpus for msi/msix interrupt handling.

Revision Contents
Changeset List

Path

Size

sys/

x86/

mp_x86.c

7 lines

Diff 135631

View Options

Hyper-V: vPCI: limit 64 cpus for msi/msix interrupt handling on FreeBSD 13.xClosedPublicActions