Page MenuHomeFreeBSD
Differential D44253

timerfd_create: accept CLOCK_UPTIME/CLOCK_BOOTTIME
ClosedPublic
Actions

Authored by bapt on Mar 6 2024, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 10:03 AM
Unknown Object (File)
Mar 13 2024, 4:26 AM
Unknown Object (File)
Mar 8 2024, 12:54 AM
Unknown Object (File)
Mar 7 2024, 11:51 AM
Unknown Object (File)
Mar 7 2024, 11:15 AM
Unknown Object (File)
Mar 7 2024, 9:03 AM
Unknown Object (File)
Mar 7 2024, 7:46 AM
Unknown Object (File)
Mar 6 2024, 6:36 PM
Subscribers
arichardson
des
imp
olce

Details

Reviewers
dchagin
des
imp
Commits
rG104328e63034: timerfd_create: accept CLOCK_UPTIME/CLOCK_BOOTTIME
rGcf742faa39a5: timerfd_create: accept CLOCK_UPTIME/CLOCK_BOOTTIME
Summary

This is a common use case when using timerfd_create to actually use
it with CLOCK_BOOTTIME on linux which is CLOCK_UPTIME for us.

Tested with the fnott notification software

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56481
Build 53369: arc lint + arc unit

Event Timeline

bapt created this revision.Mar 6 2024, 2:13 PM
Herald added subscribers: olce, imp. · View Herald TranscriptMar 6 2024, 2:13 PM
bapt requested review of this revision.Mar 6 2024, 2:13 PM
Harbormaster completed remote builds in B56480: Diff 135454.Mar 6 2024, 2:13 PM
bapt added a reviewer: dchagin.Mar 6 2024, 2:25 PM
des requested changes to this revision.Mar 6 2024, 3:32 PM
des added a subscriber: des.
des added inline comments.
sys/kern/sys_timerfd.c
436–445

either wrap this line or convert to a switch

This revision now requires changes to proceed.Mar 6 2024, 3:32 PM
bapt updated this revision to Diff 135455.Mar 6 2024, 3:40 PM

convert to a switch
explicitly accept both CLOCK_UPTIME and CLOCK_BOOTTIME

Harbormaster completed remote builds in B56481: Diff 135455.Mar 6 2024, 3:40 PM
bapt marked an inline comment as done.Mar 6 2024, 3:40 PM
imp accepted this revision.Mar 6 2024, 3:43 PM
des accepted this revision.Mar 6 2024, 3:59 PM
This revision is now accepted and ready to land.Mar 6 2024, 3:59 PM
Closed by commit rGcf742faa39a5: timerfd_create: accept CLOCK_UPTIME/CLOCK_BOOTTIME (authored by bapt). · Explain WhyMar 6 2024, 5:14 PM
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rGcf742faa39a5: timerfd_create: accept CLOCK_UPTIME/CLOCK_BOOTTIME.
arichardson added a subscriber: arichardson.Mar 6 2024, 10:32 PM
arichardson added inline comments.
sys/kern/sys_timerfd.c
438

These comments should not be needed for sequential case labels

bapt added a commit: rG104328e63034: timerfd_create: accept CLOCK_UPTIME/CLOCK_BOOTTIME.Mar 18 2024, 2:40 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
13 lines

Diff 135455

View Options

sys/kern/sys_timerfd.c

Loading...