Page MenuHomeFreeBSD

Remove fiempty lines at the beginning of files
AbandonedPublic

Authored by minsoochoo0122_proton.me on Jan 3 2024, 5:08 AM.
Referenced Files
Unknown Object (File)
Thu, May 9, 11:00 PM
Unknown Object (File)
Thu, May 9, 6:24 PM
Unknown Object (File)
Thu, May 2, 6:17 PM
Unknown Object (File)
Fri, Apr 26, 2:50 AM
Unknown Object (File)
Apr 8 2024, 8:44 AM
Unknown Object (File)
Apr 8 2024, 7:31 AM
Unknown Object (File)
Feb 10 2024, 9:42 PM
Unknown Object (File)
Feb 3 2024, 8:23 AM

Details

Summary

When removed $FREEBSD$ tag from svn, first line of some files (most of them are Makefiles) remain empty. This is still work in progress and each files need to be checked so these changes do not break anything.

contrib, sys/contrib, crypto, cddl/compat are not affected since they are imported from upstream.

Test Plan

make buildworld and make buildkernel
regression tests and kyua tests might be needed to verify that nothing is broken in this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 55214
Build 52103: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 3 2024, 5:08 AM
Herald added a reviewer: bdrewery. · View Herald Transcript
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: gnn. · View Herald Transcript
Herald added a reviewer: gnn. · View Herald Transcript
Herald added a reviewer: jilles. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: brooks. · View Herald Transcript
Herald added a reviewer: cy. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: cam. · View Herald Transcript

Too many files to review.

In theory it isn't terrible but id be skittish about it...

Woof.

IMO this does not belong in Phabricator.

Sadly this should of been caught and corrected during the removal of $FreeBSD$. It should be possible to mechanically validate the raw diff with something:
net:root {1024}# egrep -v '^@@ |^\+\+\+|^---' D43290.diff | egrep '^-|^\+' | sort -u

net:root {1025}#
Ie, the diff does infact ONLY remove blank lines and adds nothing

I think this should be done by a committer who can commit to the repo without having to upload the patch on phabricator. Closing revision.