Page MenuHomeFreeBSD
Differential D42596

arm64: Allow userspace to be built with PAC and BTI
ClosedPublic
Actions

Authored by andrew on Nov 14 2023, 3:16 PM.
Tags
None
Referenced Files
F84439394: D42596.diff
Thu, May 23, 9:37 PM
Unknown Object (File)
Wed, May 22, 6:12 PM
Unknown Object (File)
Wed, May 22, 12:01 PM
Unknown Object (File)
Sun, May 19, 6:51 PM
Unknown Object (File)
Sat, May 11, 4:47 PM
Unknown Object (File)
Sat, May 11, 4:47 PM
Unknown Object (File)
Sun, May 5, 4:22 PM
Unknown Object (File)
Sat, May 4, 4:45 PM
View All 24 Files
Subscribers
bdrewery
dab
emaste
imp

Details

Reviewers
manu
emaste
Group Reviewers
arm64
Commits
rG82854693aec1: arm64: Allow userspace to be built with PAC and BTI

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57174
Build 54062: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 14 2023, 3:16 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 14 2023, 3:16 PM
Herald added subscribers: dab, emaste, imp, bdrewery. · View Herald Transcript
andrew requested review of this revision.Nov 14 2023, 3:16 PM
andrew added a parent revision: D42595: arm64: Mark the armv8 crc32c as supporting BTI.
Harbormaster completed remote builds in B54418: Diff 130078.Nov 14 2023, 3:16 PM
emaste added a comment.Nov 14 2023, 3:19 PM

Description file(s) to go in tools/build/options/ are missing

andrew updated this revision to Diff 130079.Nov 14 2023, 3:23 PM

Remove debugging

Harbormaster completed remote builds in B54419: Diff 130079.Nov 14 2023, 3:24 PM
andrew updated this revision to Diff 137312.Apr 18 2024, 4:34 PM

Rebase and disable until we can check all relavant toolchains support it

Harbormaster completed remote builds in B57173: Diff 137312.Apr 18 2024, 4:34 PM
emaste added inline comments.Apr 18 2024, 4:39 PM
lib/libomp/Makefile
3

Should be :=no? (Even though we're setting it before including other things.)

andrew updated this revision to Diff 137313.Apr 18 2024, 4:39 PM

Add missing WITH/WITHOUT files

Harbormaster completed remote builds in B57174: Diff 137313.Apr 18 2024, 4:40 PM
andrew updated this revision to Diff 138900.Wed, May 22, 9:47 AM

Use := to disable branch protection

Harbormaster completed remote builds in B57839: Diff 138900.Wed, May 22, 9:47 AM
andrew updated this revision to Diff 138927.Wed, May 22, 2:49 PM

:= -> = again after a comment from @emaste on IRC

Harbormaster completed remote builds in B57848: Diff 138927.Wed, May 22, 2:49 PM
emaste accepted this revision.Wed, May 22, 3:08 PM

LGTM. Should probably expand the WITH_BRANCH_PROTECTION text though, at least mentioning on which architecture it applies (can be enabled / has an effect).

This revision is now accepted and ready to land.Wed, May 22, 3:08 PM
Closed by commit rG82854693aec1: arm64: Allow userspace to be built with PAC and BTI (authored by andrew). · Explain WhyWed, May 22, 5:03 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG82854693aec1: arm64: Allow userspace to be built with PAC and BTI.

Revision Contents
Changeset List

PathSize
lib/
libomp/
3 lines
share/
mk/
6 lines
5 lines
6 lines
stand/
3 lines
tools/
build/
options/
1 line
1 line

Diff 137313

View Options

lib/libomp/Makefile

Loading...
View Options

share/mk/bsd.lib.mk

Loading...
View Options

share/mk/bsd.opts.mk

Loading...
View Options

share/mk/bsd.prog.mk

Loading...
View Options

stand/Makefile.inc

Loading...
View Options

tools/build/options/WITHOUT_BRANCH_PROTECTION

Loading...
View Options

tools/build/options/WITH_BRANCH_PROTECTION

Loading...