Fix /root permissions after 'make installworld'
ClosedPublic
Actions

Authored by gbe on Oct 29 2023, 6:40 AM.

Details

Reviewers

emaste
jilles

Commits

rG1023abd5b60f: Fix /root permissions after 'make installworld'
rGc9ceff3c1fa6: Fix /root permissions after 'make installworld'
rGa6ed8c959303: Fix /root permissions after 'make installworld'

Summary

According to /etc/mtree/BSD.root.dist /root should have
0750 permissions, but "make installworld" changes these to 0755.

This is caused by the installation of configuration directories
of "csh" and "sh".

Correct these by specifing the correct default /root permissions.

PR: 273342

Test Plan

make buildworld && make instalworld

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gbe created this revision.Oct 29 2023, 6:40 AM

Herald added a reviewer: jilles. · View Herald TranscriptOct 29 2023, 6:40 AM

Herald added a subscriber: imp. · View Herald Transcript

gbe requested review of this revision.Oct 29 2023, 6:40 AM

Harbormaster completed remote builds in B54199: Diff 129492.Oct 29 2023, 6:40 AM

Tested by myself on head, stable/14 and releng/14.0.

jlduran_gmail.com added a subscriber: jlduran_gmail.com.Nov 3 2023, 10:55 AM

Wouldn't it make more sense, to match the default set in etc/mtree/BSD.root.dist? Otherwise, if someone adjusts BSD.root.dist, there's a conflict again (as it already happend with D23392).

This looks like a reasonable quick fix, but I think it's unfortunate the /root directory permissions are specified both in bsd.dirs.mk variables and in the BSD.root.dist mtree file. It looks like the bsd.dirs.mk variables are required because of pkgbase.

This revision is now accepted and ready to land.Nov 14 2023, 10:06 PM

Closed by commit rGa6ed8c959303: Fix /root permissions after 'make installworld' (authored by Thomas Eberhardt <sneakywumpus@gmail.com>, committed by gbe). · Explain WhyNov 16 2023, 10:00 AM

This revision was automatically updated to reflect the committed changes.

gbe added a commit: rGa6ed8c959303: Fix /root permissions after 'make installworld'.

gbe added a commit: rGc9ceff3c1fa6: Fix /root permissions after 'make installworld'.Dec 1 2023, 7:16 AM

gbe added a commit: rG1023abd5b60f: Fix /root permissions after 'make installworld'.