pf tests: Fix missing pf enabling
AbandonedPublic
Actions

Authored by kp on Oct 25 2023, 5:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 13, 12:56 PM

	Unknown Object (File)
	Sun, May 12, 11:40 AM

	Unknown Object (File)
	Thu, May 9, 4:00 PM

	Unknown Object (File)
	May 2 2024, 2:51 AM

	Unknown Object (File)
	Apr 29 2024, 6:34 AM

	Unknown Object (File)
	Feb 7 2024, 9:47 PM

	Unknown Object (File)
	Dec 28 2023, 7:24 PM

	Unknown Object (File)
	Dec 23 2023, 3:41 AM

Subscribers

Details

Reviewers

vegeta_tuxpowered.net

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Oct 25 2023, 5:41 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptOct 25 2023, 5:41 PM

vegeta_tuxpowered.net requested review of this revision.Oct 25 2023, 5:41 PM

vegeta_tuxpowered.net mentioned this in D42355: pf: Fix packet reassembly.Oct 25 2023, 5:48 PM

The bug is in D42355, where we remove part of this test case, including the pfctl -e.
This fixes it, but I'm going to squash this together with the other review to keep the history simpler.

In D42363#966766, @kp wrote:

The bug is in D42355, where we remove part of this test case, including the pfctl -e.
This fixes it, but I'm going to squash this together with the other review to keep the history simpler.

Good catch! I thought it's something totally separate, my bad.

Commandeering to abandon. We included this in D42355.

kp abandoned this revision.Oct 29 2023, 9:12 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

fragmentation_compat.sh

1 line

Diff 129385

View Options

tests/sys/netpfil/pf/fragmentation_compat.sh

pf tests: Fix missing pf enablingAbandonedPublicActions