localedef: expand the default charmap
ClosedPublic
Actions

Authored by kevans on Sep 2 2023, 6:36 AM.

Details

Reviewers

bapt
yuripv
andrew

Commits

rG3a7ffe206ce7: localedef: expand the default charmap

Summary

POSIX defines a number of other control characters as well as
alternative aliases for some that should be provided in the default set,
so let's go ahead and add those.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sep 2 2023, 6:36 AM

Herald added a reviewer: andrew. · View Herald TranscriptSep 2 2023, 6:36 AM

Herald added a subscriber: imp. · View Herald Transcript

kevans requested review of this revision.Sep 2 2023, 6:36 AM

Harbormaster completed remote builds in B53408: Diff 126810.Sep 2 2023, 6:36 AM

kevans added a child revision: D41693: localedef: add newlines to error messages.Sep 2 2023, 6:36 AM

Just wondering what triggered this change, i.e. does it fix any known issues?

In D41692#950586, @yuripv wrote:

Just wondering what triggered this change, i.e. does it fix any known issues?

Not upstream, but we have a downstream customer with some POSIX-conformant locale definitions that they want to use with our localedef(1). I believe they only really need a subset, but it seemed like a good opportunity to complete the set

yuripv accepted this revision.Sep 5 2023, 5:02 AM

This revision is now accepted and ready to land.Sep 5 2023, 5:02 AM

bapt accepted this revision.Sep 5 2023, 9:34 AM

Closed by commit rG3a7ffe206ce7: localedef: expand the default charmap (authored by kevans). · Explain WhySep 5 2023, 7:09 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG3a7ffe206ce7: localedef: expand the default charmap.