Page MenuHomeFreeBSD

pf: Enable the syncookie feature for IPv6 and reduce indentation
ClosedPublic

Authored by vegeta_tuxpowered.net on Aug 18 2023, 7:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 4:59 AM
Unknown Object (File)
Mar 19 2024, 4:07 AM
Unknown Object (File)
Mar 11 2024, 1:21 PM
Unknown Object (File)
Mar 5 2024, 8:35 AM
Unknown Object (File)
Jan 14 2024, 9:52 AM
Unknown Object (File)
Dec 23 2023, 3:49 AM
Unknown Object (File)
Dec 10 2023, 8:10 PM
Unknown Object (File)
Nov 7 2023, 9:11 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I didn't realise we didn't support synproxy on IPv6, and I'm a little confused, given that we have the pf/synproxy:local_v6 test case which appears to pass.

I'll take a deeper look sometime next week. If you get a moment can you create a test case like synproxy:synproxy for IPv6?

In D41502#945583, @kp wrote:

I didn't realise we didn't support synproxy on IPv6, and I'm a little confused, given that we have the pf/synproxy:local_v6 test case which appears to pass.

I'll take a deeper look sometime next week. If you get a moment can you create a test case like synproxy:synproxy for IPv6?

I've named the commit wrong. Sorry, this is for syncookie, not for synproxy.

vegeta_tuxpowered.net retitled this revision from pf: Enable synproxy feature for IPv6 and reduce indentation to pf: Enable the syncookie feature for IPv6 and reduce indentation.Aug 18 2023, 3:48 PM

Ah, indeed.
I also thought that there was IPv6 support there, but clearly I was wrong.

Same question about the test though ;)

At first glance that looks sane enough. I may end up splitting this into two commits (one for the indentation, one for the IPv6 support). Again, sometime next week. If I've not committed (or taken issue with the commit, but I doubt that) by the 28th feel free to shout at me.

Add the missing "Respond to SYN with a syncookie" part.

I’ve got a couple of ipv6 test cases, and the nostate one does at least fail (without your patches).
So you don’t need to bother with tests. I’ll commit mine with your patches.

Also, is this Sponsored by: InnoGames GmbH?

In D41502#945945, @kp wrote:

Also, is this Sponsored by: InnoGames GmbH?

Yes it is.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 21 2023, 1:25 PM
Closed by commit rG9642d948c08d: pf: reduce indentation (authored by vegeta_tuxpowered.net, committed by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.