Page MenuHomeFreeBSD

nvme: Be less verbose when cancelling I/O or admin commands
ClosedPublic

Authored by imp on Aug 3 2023, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 5:05 AM
Unknown Object (File)
Wed, May 1, 11:09 PM
Unknown Object (File)
Wed, May 1, 10:22 PM
Unknown Object (File)
Wed, May 1, 9:49 PM
Unknown Object (File)
Apr 7 2024, 6:00 AM
Unknown Object (File)
Dec 3 2023, 9:20 AM
Unknown Object (File)
Nov 2 2023, 12:01 PM
Unknown Object (File)
Oct 18 2023, 11:40 AM
Subscribers

Details

Summary

When we're resetting, and there's outstanding I/O that we're cancelling,
only report we're cancelling the I/O once rather than once per
I/O. Likewise when we reschedule the I/O. We don't need to say for each
one that we're cancelling/rescheduling something, and then report the
I/O that we're doing. Likewise with cancelling admin commands (we never
retry them here, so a similar change isn't needed).

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Aug 3 2023, 10:41 PM

I'd just use !TAILQ_EMPTY() instead of TAILQ_FIRST() != NULL. Also while there I would remove extra STAILQ_EMPTY() before STAILQ_FIRST().

This revision is now accepted and ready to land.Aug 4 2023, 12:46 AM
sys/dev/nvme/nvme_qpair.c
1255–1256

I would also maybe go ahead and spell out report.

sys/dev/nvme/nvme_qpair.c
1255–1256

OK. I'd already made the first change... And I spelled it out here and elsewhere.

chuck added inline comments.
sys/dev/nvme/nvme_qpair.c
1294

Would it make sense to have the logging similar for Admin and I/O? I.e., either change this to done aborting outstanding i/o or change the Admin case above to done aborting?

sys/dev/nvme/nvme_qpair.c
1294

Yes. I think it would.
Thanks!