Page MenuHomeFreeBSD

Restore and document -ps / -nps option.
ClosedPublic

Authored by des on Jun 28 2023, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 8:17 PM
Unknown Object (File)
Mon, Apr 29, 2:10 PM
Unknown Object (File)
Sat, Apr 27, 4:44 PM
Unknown Object (File)
Apr 13 2024, 6:20 AM
Unknown Object (File)
Apr 1 2024, 4:05 AM
Unknown Object (File)
Mar 30 2024, 7:58 PM
Unknown Object (File)
Dec 31 2023, 5:09 PM
Unknown Object (File)
Dec 27 2023, 1:13 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jun 28 2023, 6:26 PM
kevans added a subscriber: kevans.

LGTM, though I'd still give pstef a bit to weigh in as the de facto maintainer.

This revision is now accepted and ready to land.Jun 28 2023, 6:36 PM

Manual page English LGTM. Can't attest to anything else.

If it's just an effort to synchronize with OpenBSD then I vote against this change. I intentionally removed this option years ago, so I have to assume that the difference here comes from the fact that OpenBSD didn't.
If, however, you want to restore this functionality for whatever reason, I will only make a face and accept it.

Tangentially, if anybody wants to improve our indent, they should look into synchronizing with NetBSD indent. The story here is convoluted, so I'll spare you the details, but currently that one seems to be the most advanced fork of the BSD indents.

If it's just an effort to synchronize with OpenBSD then I vote against this change. I intentionally removed this option years ago, so I have to assume that the difference here comes from the fact that OpenBSD didn't.
If, however, you want to restore this functionality for whatever reason, I will only make a face and accept it.

No, I'm not trying to synchronize with OpenBSD. I need this option for unrelated (or, rather, very indirectly related) reasons. I didn't realize we'd had it in the past; I'll amend the commit message to note that we're restoring it rather than copying it.

des retitled this revision from Add and document -ps / -nps option, cf. OpenBSD. to Restore and document -ps / -nps option..Jun 29 2023, 1:51 PM
This revision was automatically updated to reflect the committed changes.