Page MenuHomeFreeBSD
Differential D38378

usr.bin/find: Fix -acl, broken by D13306 (since FreeBSD 12.0)
AcceptedPublic
Actions

Authored by phil_krylov.eu on Feb 3 2023, 11:12 PM.
Tags
None
Referenced Files
F84188981: D38378.diff
Mon, May 20, 3:09 PM
Unknown Object (File)
Sat, May 11, 7:54 PM
Unknown Object (File)
Fri, May 3, 5:33 AM
Unknown Object (File)
Apr 9 2024, 3:05 PM
Unknown Object (File)
Apr 3 2024, 2:16 PM
Unknown Object (File)
Mar 8 2024, 8:35 AM
Unknown Object (File)
Feb 27 2024, 9:11 AM
Unknown Object (File)
Feb 10 2024, 9:25 AM
View All 29 Files
Subscribers
imp

Details

Reviewers
arichardson
imp
Summary

It' s been discussed on D13306 but never got committed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

phil_krylov.eu created this revision.Feb 3 2023, 11:12 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2023, 11:12 PM
phil_krylov.eu requested review of this revision.Feb 3 2023, 11:12 PM
lwhsu added a reviewer: arichardson.Feb 4 2023, 12:23 PM
imp accepted this revision.Feb 4 2023, 2:59 PM
imp added inline comments.
usr.bin/find/option.c
45

This looks fine, and matches what was discussed in D13306.

The only weird edge case I can think of with it would be trying to build in a Linux chroot but with the FreeBSD clang compiler so FreeBSD is defined.... That's weird enough that I think we can safely allow that case not to work :)

This revision is now accepted and ready to land.Feb 4 2023, 2:59 PM
arichardson accepted this revision.Feb 4 2023, 5:45 PM

Slight preference for __has_include but this also LGTM.

imp added a comment.Feb 4 2023, 5:55 PM
In D38378#872535, @arichardson wrote:

Slight preference for __has_include but this also LGTM.

In D13306 that was rejected because gcc6 didn't support it. However, time has marched on from then. If it's OK to use, then I'll land this review with that change.

phil_krylov.eu added a comment.Aug 25 2023, 11:54 AM

What can I do to get this merged?

Revision Contents
Changeset List

PathSize
usr.bin/
find/
4 lines

Diff 116445

View Options

usr.bin/find/option.c

Loading...