Page MenuHomeFreeBSD

wg_noise: Drop atomics for kp_can_send.
AbandonedPublic

Authored by jhb on Jul 29 2022, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 5 2024, 11:21 AM
Unknown Object (File)
Apr 22 2024, 8:20 AM
Unknown Object (File)
Apr 7 2024, 7:59 AM
Unknown Object (File)
Apr 7 2024, 4:30 AM
Unknown Object (File)
Feb 21 2024, 9:18 AM
Unknown Object (File)
Jan 10 2024, 10:24 PM
Unknown Object (File)
Dec 24 2023, 3:42 PM
Unknown Object (File)
Dec 20 2023, 3:11 AM
Subscribers

Details

Reviewers
markj
Summary

Using atomics for only load and store seem pointless. The only ones
that might matter are covered by fences in epoch_*.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46684
Build 43573: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jul 29 2022, 4:57 PM

Is this patch still relevant?

I think this is superseded by commit e32e1a160e01a no?

I think this is superseded by commit e32e1a160e01a no?

Kind of. This change drops atomics that I think aren't really needed, but they are also fairly harmless. It is true that initially when trying to switch wg(4) to atomic(9) we didn't support bools for atomic(9), but I ended up adding bools to atomic(9) so we could switch without having to remove any. I still think these atomics aren't needed, per se but they are also pretty harmless.