Differential D31305

bridge tests: verify that we can't change MTU of bridge member interfaces
ClosedPublic
Actions

Authored by kp on Jul 26 2021, 11:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 14, 6:06 AM

	Unknown Object (File)
	Thu, May 9, 9:43 AM

	Unknown Object (File)
	Wed, May 8, 10:44 PM

	Unknown Object (File)
	Apr 19 2024, 1:29 AM

	Unknown Object (File)
	Apr 17 2024, 3:43 AM

	Unknown Object (File)
	Mar 28 2024, 8:14 PM

	Unknown Object (File)
	Jan 13 2024, 7:21 AM

	Unknown Object (File)
	Dec 21 2023, 4:33 AM

View All 31 Files

Subscribers

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG441d15a4825c: bridge tests: verify that we can't change MTU of bridge member interfaces

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jul 26 2021, 11:55 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJul 26 2021, 11:55 AM

kp requested review of this revision.Jul 26 2021, 11:55 AM

kp added a parent revision: D31304: net: disallow MTU changes on bridge member interfaces.

Harbormaster completed remote builds in B40672: Diff 92740.Jul 26 2021, 11:56 AM

donner accepted this revision as: donner.Jul 27 2021, 6:05 AM

donner added a subscriber: donner.

donner added inline comments.

tests/sys/net/if_bridge_test.sh
583	That's an interesting case. Why not try to set 2000?

This revision is now accepted and ready to land.Jul 27 2021, 6:05 AM

kp added inline comments.Jul 27 2021, 9:30 AM

tests/sys/net/if_bridge_test.sh
583	This verifies that we can't change bridge member interface MTUs. I think that trying to set it to the value it already has we'd still reject it and return an error. So if we tried to set 2000 we'd still get the error, but we couldn't verify that the value really didn't change.

This revision was landed with ongoing or failed builds.Jul 28 2021, 8:07 PM

Closed by commit rG441d15a4825c: bridge tests: verify that we can't change MTU of bridge member interfaces (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG441d15a4825c: bridge tests: verify that we can't change MTU of bridge member interfaces.

Revision Contents
Changeset List

Path

Size

tests/

sys/

net/

if_bridge_test.sh

5 lines

Diff 92904

tests/sys/net/if_bridge_test.sh

Loading...