HomeFreeBSD

route: error on IPv4 network routes with incorrect destination

Description

route: error on IPv4 network routes with incorrect destination

Route destinations like 10/8 are most likely intended as a shorthand
for 10.0.0.0/8, but instead it means 0.0.0.10/8, which includes
only bits in the host part of the mask, and hence adds a route to
0.0.0.0/8. In 12.x, there was code to "do what I mean", which was
removed as part of a cleanup of old network class remnants. Given
that we have gone this long without that code, do not restore that
behavior. Instead, detect the issue and produce an error.
Specifically, if there are no dots in a numeric IPv4 address, the
mask is specified with CIDR notation (using a slash), and there are
bits set in the host part, produce an error like this for 10/8:

route: malformed address, bits set after mask; 10 means 0.0.0.10

PR: 258874
Reviewed by: melifaro, emaste
Differential Revision: https://reviews.freebsd.org/D43384

(cherry picked from commit b9e8ae1d8a424194b4e185359da4ded163f24f4e)

Details

Provenance
karelsAuthored on Jan 15 2024, 9:14 PM
Reviewer
melifaro
Differential Revision
D43384: route: error on IPv4 network routes with incorrect destination
Parents
rG17e941a0c88c: kerberos5: Mitigate the possibility of using an old libcrypto
Branches
Unknown
Tags
Unknown