HomeFreeBSD

vfs_vnops.c: Fix vn_generic_copy_file_range() for truncation

Description

vfs_vnops.c: Fix vn_generic_copy_file_range() for truncation

When copy_file_range(2) was first being developed,
*inoffp + len had to be <= infile_size or an error was
returned. This semantic (as defined by Linux) changed
to allow *inoffp + len to be greater than infile_size and
the copy would end at *inoffp + infile_size.

Unfortunately, the code that decided if the outfd should
be truncated in length did not get updated for this
semantics change.
As such, if a copy_file_range(2) is done, where infile_size - *inoffp
is less that outfile_size but len is large, the outfd file is truncated
when it should not be. (The semantics for this for Linux is to not
truncate outfd in this case.)

This patch fixes the problem. I believe the calculation is safe
for all non-negative values of outsize, *outoffp, *inoffp and insize,
which should be ok, since they are all guaranteed to be non-negative.

Note that this bug is not observed over NFSv4.2, since it truncates
len to infile_size - *inoffp.

PR: 276045
Reviewed by: asomers, kib
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D43258

Details

Provenance
rmacklemAuthored on Dec 31 2023, 11:55 PM
Reviewer
asomers
Differential Revision
D43258: Fix copy_file_range(2) so that it does not truncate the output file erroneously
Parents
rG38c63bdc4625: libdtrace: decode all tcp header flags and add
Branches
Unknown
Tags
Unknown