Page MenuHomeFreeBSD

pfsenseProject
ActivePublic

Recent Activity

Sep 7 2023

delphij added a watcher for pfsense: delphij.
Sep 7 2023, 4:39 PM

Jun 15 2023

gjb removed a watcher for pfsense: gjb.
Jun 15 2023, 3:46 PM

Jun 12 2023

franco_opnsense.org added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

For emphasis: I said for clarity it's beneficial to read the VLAN ID and at least show it. Doing it here assuming it's zero but giving no way to verify is simply risky.

Jun 12 2023, 7:16 PM · pfsense
rcm added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

For the print alone it's beneficial to read the VLAN ID and show it. The way it is now it just pushes the maintenance cost to a future point/individual if the PCAP implementation doesn't do what is assumed here (and not even correctly documented as a comment).

Jun 12 2023, 7:12 PM · pfsense
franco_opnsense.org added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

For the print alone it's beneficial to read the VLAN ID and show it. The way it is now it just pushes the maintenance cost to a future point/individual if the PCAP implementation doesn't do what is assumed here (and not even correctly documented as a comment).

Jun 12 2023, 7:09 PM · pfsense
cy closed D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:30 PM · pfsense
rcm updated the summary of D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense
rcm updated the summary of D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense
rcm added inline comments to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense
franco_opnsense.org added inline comments to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 12 2023, 2:29 PM · pfsense

Jun 11 2023

cy accepted D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

LGTM. I will commit this on Monday for you.

Jun 11 2023, 10:16 PM · pfsense
cy added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
In D40442#921594, @rcm_rcm.sh wrote:

http://lists.infradead.org/pipermail/hostap/2023-June/041627.html

I managed to get subscribed to the hostap mailing list. I also brought along another patch from FreeBSD so the l2 receive code should now be consistent between the two trees.

Jun 11 2023, 10:16 PM · pfsense

Jun 9 2023

rcm added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

I managed to get subscribed to the hostap mailing list. I also brought along another patch from FreeBSD so the l2 receive code should now be consistent between the two trees.

Jun 9 2023, 4:33 PM · pfsense

Jun 8 2023

rcm updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

There was a regression in the latest diff. That has been fixed now.

Jun 8 2023, 7:13 PM · pfsense
rcm added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
In D40442#921284, @cy wrote:

Can you also please send this to our upstream, hostap@lists.infradead.org. I prefer not having our source diverge from upstream too much.

Other than that, looks good. I'll do some regression testing here.

Jun 8 2023, 1:23 PM · pfsense
rcm updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

Not sure why the last diff did not apply. I recreated it. Hopefully this one works.

Jun 8 2023, 2:54 AM · pfsense
cy requested changes to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

Patch does not apply.

Jun 8 2023, 12:18 AM · pfsense
cy added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

slippy$ git apply /tmp/D40442.diff
error: patch failed: contrib/wpa/src/l2_packet/l2_packet_freebsd.c:99
error: contrib/wpa/src/l2_packet/l2_packet_freebsd.c: patch does not apply
slippy$ patch -C -p1 < /tmp/D40442.diff
Hmm... Looks like a unified diff to me...

The text leading up to this was:

diff --git a/contrib/wpa/src/l2_packet/l2_packet_freebsd.c b/contrib/wpa/src/l2_packet/l2_packet_freebsd.c
--- a/contrib/wpa/src/l2_packet/l2_packet_freebsd.c
+++ b/contrib/wpa/src/l2_packet/l2_packet_freebsd.c

Patching file contrib/wpa/src/l2_packet/l2_packet_freebsd.c using Plan A...
Hunk #1 succeeded at 21.
Hunk #2 failed at 100.
Hunk #3 failed at 131.
2 out of 3 hunks failed while patching contrib/wpa/src/l2_packet/l2_packet_freebsd.c
Hmm... Ignoring the trailing garbage.
done
slippy$

Jun 8 2023, 12:16 AM · pfsense
cy added a comment to D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

Can you also please send this to our upstream, hostap@lists.infradead.org. I prefer not having our source diverge from upstream too much.

Jun 8 2023, 12:14 AM · pfsense
cy added a reviewer for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames: bz.
Jun 8 2023, 12:06 AM · pfsense

Jun 7 2023

rcm added a member for pfsense: rcm.
Jun 7 2023, 8:20 PM
rcm retitled D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames from wip: wpa_supplicant: Enable receiving priority tagged (VID 0) frames to wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 7 2023, 4:38 PM · pfsense
rcm updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

This revision narrows the scope of change to only focus on FreeBSD related L2 packet handling in wpa_supplicant. The previous revision updated all occurrences of the filter program, however failed to account for packet and length offsets when handling encapsulated frames. Someone else can pick up the torch and provide patches for other platforms upstream as-needed.

Jun 7 2023, 4:31 PM · pfsense
rcm retitled D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames from wpa_supplicant: Enable receiving priority tagged (VID 0) frames to wip: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 7 2023, 1:31 PM · pfsense
lwhsu added a reviewer for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames: cy.
Jun 7 2023, 2:07 AM · pfsense

Jun 6 2023

rcm requested review of D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Jun 6 2023, 7:29 PM · pfsense

May 24 2022

linnemannr_gmail.com added a member for pfsense: linnemannr_gmail.com.
May 24 2022, 10:35 PM

Mar 25 2022

scottl removed a member for pfsense: scottl.
Mar 25 2022, 10:08 PM

Aug 17 2021

mjg added a member for pfsense: mjg.
Aug 17 2021, 6:39 PM

May 27 2021

jim_netgate.com added a member for pfsense: jim_netgate.com.
May 27 2021, 5:52 PM

May 26 2021

brd added a member for pfsense: brd.
May 26 2021, 8:44 PM
grehan added a member for pfsense: grehan.
May 26 2021, 8:35 PM
loos added a member for pfsense: loos.
May 26 2021, 7:55 PM
garga added a member for pfsense: garga.
May 26 2021, 6:45 PM
scottl added a member for pfsense: scottl.
May 26 2021, 6:27 PM
gjb added a watcher for pfsense: gjb.
May 26 2021, 6:26 PM
kp added a watcher for pfsense: kp.
May 26 2021, 6:09 PM
emaste renamed pfsense from pfSense to pfsense.
May 26 2021, 6:08 PM
emaste created pfsense.
May 26 2021, 6:08 PM