Page MenuHomeFreeBSD

zec (Marko Zec)
User

Projects

User Details

User Since
Dec 14 2014, 3:26 PM (491 w, 4 d)

Recent Activity

Tue, May 14

zec committed rG9ae078121d3f: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
Tue, May 14, 8:40 PM
zec committed rG354fa04f5ea1: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
Tue, May 14, 8:40 PM
zec committed rG43571fe7c8dc: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
Tue, May 14, 8:40 PM
zec committed rGf68ecf5d4fbd: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
Tue, May 14, 8:40 PM
zec committed rG416679ecabd6: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
Tue, May 14, 8:40 PM
zec committed rG2b9843e268fa: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
Tue, May 14, 8:40 PM
zec committed rG40a1183ac774: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
Tue, May 14, 8:40 PM
zec committed rG52075e4cfabc: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
Tue, May 14, 8:39 PM
zec committed rG0418d7a09037: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
Tue, May 14, 8:39 PM
zec committed rG1261fc325c3c: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
Tue, May 14, 8:39 PM
zec committed rGe474704b9c49: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
Tue, May 14, 8:39 PM
zec committed rGdf376a714af6: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
Tue, May 14, 8:39 PM
zec committed rG64136682ba16: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
Tue, May 14, 8:39 PM
zec committed rGe9927f4e6129: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
Tue, May 14, 8:39 PM

Tue, May 7

zec committed rGb24e353f9e58: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
Tue, May 7, 3:50 PM
zec committed rG4aa275f12da4: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
Tue, May 7, 3:34 PM
zec committed rG7a5de1d4cc6a: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
Tue, May 7, 3:27 PM
zec committed rGed541e201a05: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
Tue, May 7, 3:13 PM

Mon, May 6

zec committed rG5295e891d0d3: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
Mon, May 6, 6:43 PM
zec committed rG858010643c54: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
Mon, May 6, 6:39 PM
zec committed rG308caa38cdf5: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
Mon, May 6, 6:24 PM

Sep 23 2023

zec committed rG03ef737c544d: ng_eiface: switch VNETs when injecting mbufs into netgraph (authored by zec).
ng_eiface: switch VNETs when injecting mbufs into netgraph
Sep 23 2023, 9:25 AM

Jun 15 2023

zec committed rG32b28e3ae28f: route.8: mention DXR in FIB_ALGO section (authored by zec).
route.8: mention DXR in FIB_ALGO section
Jun 15 2023, 5:24 AM
zec added a reverting change for rGfb31ad53c471: route.8: mention DXR in FIB_ALGO section: rGfc17cf76153d: Back out fb31ad53c471e01ba473b2fb038c0cff6253654b, which was committed.
Jun 15 2023, 5:20 AM
zec committed rGfc17cf76153d: Back out fb31ad53c471e01ba473b2fb038c0cff6253654b, which was committed (authored by zec).
Back out fb31ad53c471e01ba473b2fb038c0cff6253654b, which was committed
Jun 15 2023, 5:20 AM

May 27 2023

zec committed rGfb31ad53c471: route.8: mention DXR in FIB_ALGO section (authored by zec).
route.8: mention DXR in FIB_ALGO section
May 27 2023, 8:33 AM

May 4 2022

zec committed rGc4585b938a04: tests: vnet tests started failing in CI, disable temporarily (authored by zec).
tests: vnet tests started failing in CI, disable temporarily
May 4 2022, 4:30 AM
zec closed D35119: Disable VNET tests on CI temporarily.
May 4 2022, 4:30 AM

May 3 2022

zec added a reverting change for rG91f44749c6fe: ifnet: make if_index global: rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global".
May 3 2022, 5:30 PM
zec committed rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global" (authored by zec).
VNET: Revert "ifnet: make if_index global"
May 3 2022, 5:30 PM
zec added a reverting change for rGe1882428dcbb: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:30 PM
zec added a reverting change for rG165746f4e4bf: dummynet: use m_rcvif_serialize/restore when queueing packets: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".
May 3 2022, 5:30 PM
zec added a reverting change for rG703e533da5e2: mbuf: do not restore dying interfaces: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:30 PM
zec added a reverting change for rG6871de9363e5: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs: rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs".
May 3 2022, 5:30 PM
zec added a reverting change for D33672: ifnet: make if_index global: rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global".
May 3 2022, 5:29 PM
zec committed rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces" (authored by zec).
Revert "mbuf: do not restore dying interfaces"
May 3 2022, 5:29 PM
zec committed rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets" (authored by zec).
Revert "dummynet: use m_rcvif_serialize/restore when queueing packets"
May 3 2022, 5:29 PM
zec added a reverting change for D33266: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:29 PM
zec added a reverting change for D34076: mbuf: do not restore dying interfaces: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:29 PM
zec committed rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs" (authored by zec).
Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs"
May 3 2022, 5:29 PM
zec committed rG711524d96123: tests/dummynet: disable since mbuf pointer serialization KPI to be backed out (authored by zec).
tests/dummynet: disable since mbuf pointer serialization KPI to be backed out
May 3 2022, 5:29 PM
zec added a reverting change for D33267: dummynet: use m_rcvif_serialize/restore when queueing packets: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".
May 3 2022, 5:29 PM
zec added a reverting change for D33268: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs: rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs".
May 3 2022, 5:29 PM

Mar 30 2022

zec requested changes to D34704: if: avoid interface destroy race.

This change builds on top if_index globalization (91f44749c6feb50f39af8805dd803e860f0418f1) which I strongly objected to, and which glebius agreed to back out as outlined in https://github.com/glebius/FreeBSD/commits/backout-ifindex, but that never happened. Hence, pls. don't proceed with this until if_index is reverted back to per-VNET state.

Mar 30 2022, 7:08 PM

Feb 6 2022

zec committed rGd055313f8c60: fib_algo: shift / mask by constants in dxr_lookup() (authored by zec).
fib_algo: shift / mask by constants in dxr_lookup()
Feb 6 2022, 7:35 AM

Jan 31 2022

zec added a watcher for network: zec.
Jan 31 2022, 10:43 PM

Jan 16 2022

zec committed rGe7abe200c27b: fib_algo: shift / mask by constants in dxr_lookup() (authored by zec).
fib_algo: shift / mask by constants in dxr_lookup()
Jan 16 2022, 11:32 PM

Oct 13 2021

zec committed rG602f81ea50d5: [fib_algo][dxr] Retire counters which are no longer used (authored by zec).
[fib_algo][dxr] Retire counters which are no longer used
Oct 13 2021, 8:10 PM
zec committed rG0eeef61aec4b: [fib_algo][dxr] Improve incremental updating strategy (authored by zec).
[fib_algo][dxr] Improve incremental updating strategy
Oct 13 2021, 8:10 PM

Oct 9 2021

zec committed rGbc8b8e106bd1: [fib_algo][dxr] Retire counters which are no longer used (authored by zec).
[fib_algo][dxr] Retire counters which are no longer used
Oct 9 2021, 11:54 AM
zec committed rG1549575f22d1: [fib_algo][dxr] Improve incremental updating strategy (authored by zec).
[fib_algo][dxr] Improve incremental updating strategy
Oct 9 2021, 11:38 AM

Sep 29 2021

zec committed rGc5981a8130e2: [fib_algo][dxr] Merge adjacent empty range table chunks. (authored by zec).
[fib_algo][dxr] Merge adjacent empty range table chunks.
Sep 29 2021, 8:44 PM
zec committed rG94ad8d7c7a35: [fib_algo][dxr] Split unused range chunk list in multiple buckets (authored by zec).
[fib_algo][dxr] Split unused range chunk list in multiple buckets
Sep 29 2021, 8:44 PM

Sep 25 2021

zec committed rG43880c511cef: [fib_algo][dxr] Split unused range chunk list in multiple buckets (authored by zec).
[fib_algo][dxr] Split unused range chunk list in multiple buckets
Sep 25 2021, 4:54 AM

Sep 20 2021

zec committed rG2ac039f7be62: [fib_algo][dxr] Merge adjacent empty range table chunks. (authored by zec).
[fib_algo][dxr] Merge adjacent empty range table chunks.
Sep 20 2021, 4:38 AM

Sep 18 2021

zec committed rGec47ee78b461: [fib algo][dxr] Fix division by zero. (authored by zec).
[fib algo][dxr] Fix division by zero.
Sep 18 2021, 5:41 PM
zec committed rGad2cca48ed53: [fib algo][dxr] Optimize trie updating. (authored by zec).
[fib algo][dxr] Optimize trie updating.
Sep 18 2021, 5:40 PM
zec committed rGd3b9b83623f2: [fib algo][dxr] Fix undefined behavior. (authored by zec).
[fib algo][dxr] Fix undefined behavior.
Sep 18 2021, 5:40 PM

Sep 16 2021

zec committed rGeb3148cc4d25: [fib algo][dxr] Fix division by zero. (authored by zec).
[fib algo][dxr] Fix division by zero.
Sep 16 2021, 2:44 PM

Sep 15 2021

zec committed rGb51f8bae570b: [fib algo][dxr] Optimize trie updating. (authored by zec).
[fib algo][dxr] Optimize trie updating.
Sep 15 2021, 8:50 PM
zec committed rG442c8a245ee3: [fib algo][dxr] Fix undefined behavior. (authored by zec).
[fib algo][dxr] Fix undefined behavior.
Sep 15 2021, 8:50 PM

Jun 20 2021

zec committed rG402ddb85eed2: Add IPv4 fib lookup performance tests with uniform keys. (authored by melifaro).
Add IPv4 fib lookup performance tests with uniform keys.
Jun 20 2021, 11:32 AM
zec committed rG09274116f4d9: tests: Revise FIB lookups per second benchmarking routines (authored by zec).
tests: Revise FIB lookups per second benchmarking routines
Jun 20 2021, 11:32 AM
zec committed rG2b6b8ea60cb5: Revise FIB lookups per second benchmarking routines. (authored by zec).
Revise FIB lookups per second benchmarking routines.
Jun 20 2021, 11:32 AM

Jun 17 2021

zec committed rG4715d948c593: Introduce DXR as an IPv4 longest prefix matching / FIB module (authored by zec).
Introduce DXR as an IPv4 longest prefix matching / FIB module
Jun 17 2021, 10:36 AM
zec committed rGb6f8436b094d: tests: Revise FIB lookups per second benchmarking routines (authored by zec).
tests: Revise FIB lookups per second benchmarking routines
Jun 17 2021, 6:52 AM

May 18 2021

zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 18 2021, 11:04 AM
zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 18 2021, 11:03 AM

May 17 2021

zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 17 2021, 10:20 AM
zec added reviewers for D30311: Revise FIB lookups per second benchmarking routines: melifaro, olivier.
May 17 2021, 10:17 AM
zec requested review of D30311: Revise FIB lookups per second benchmarking routines.
May 17 2021, 10:16 AM

May 13 2021

zec accepted D28601: netgraph/ng_bridge: Avoid cache thrashing.
May 13 2021, 5:00 PM

May 8 2021

zec added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

function dxr_build with caller dxr_change_rib_batch seems to be still active

May 8 2021, 9:06 PM

May 5 2021

zec added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

...

I assume that it's another independent routing algo module and should be considered as full replacement, not any supplementation.

May 5 2021, 8:14 PM
zec committed rG2aca58e16f50: Introduce DXR as an IPv4 longest prefix matching / FIB module (authored by zec).
Introduce DXR as an IPv4 longest prefix matching / FIB module
May 5 2021, 11:48 AM
zec closed D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 5 2021, 11:48 AM
zec committed rGa43104ebe763: Revise FIB lookups per second benchmarking routines. (authored by zec).
Revise FIB lookups per second benchmarking routines.
May 5 2021, 10:34 AM
zec closed D30096: Revise FIB lookups per second benchmarking routines.
May 5 2021, 10:34 AM

May 4 2021

zec updated the diff for D30096: Revise FIB lookups per second benchmarking routines.

Simplify injection of artificial dependencies between successive lookups in an attempt to fool / defeat apparently nifty and mighty Ryzen's value predictors.

May 4 2021, 1:42 PM
zec added inline comments to D30096: Revise FIB lookups per second benchmarking routines.
May 4 2021, 10:24 AM

May 3 2021

zec updated the summary of D30096: Revise FIB lookups per second benchmarking routines.
May 3 2021, 10:28 PM
zec requested review of D30096: Revise FIB lookups per second benchmarking routines.
May 3 2021, 10:16 PM
zec added inline comments to D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 3 2021, 6:19 PM
zec updated the diff for D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 3 2021, 6:09 PM

Apr 29 2021

zec updated the diff for D29821: Introduce DXR IPv4 LPM as a fib_algo module..

Switch to the new rib_walk_from KPI.

Apr 29 2021, 5:34 AM

Apr 21 2021

zec added inline comments to D29821: Introduce DXR IPv4 LPM as a fib_algo module..
Apr 21 2021, 12:02 PM
zec updated the diff for D29821: Introduce DXR IPv4 LPM as a fib_algo module..

Update.

Apr 21 2021, 11:36 AM

Apr 18 2021

zec requested review of D29821: Introduce DXR IPv4 LPM as a fib_algo module..
Apr 18 2021, 3:41 PM
zec accepted D29799: Fib algo: extend KPI by allowing algo to set datapath pointers..
Apr 18 2021, 1:04 PM

Apr 15 2021

zec accepted D29588: [FIB algo] Add support for the batched updates..

Do not update size of route change queue on failure.

Apr 15 2021, 9:29 AM

Apr 14 2021

zec added a comment to D29588: [FIB algo] Add support for the batched updates..

Fix case with small number of updates.

Apr 14 2021, 9:43 AM

Apr 9 2021

zec added inline comments to D29661: Appease -Wsign-compare in radix.c.
Apr 9 2021, 6:09 PM
zec added inline comments to D29661: Appease -Wsign-compare in radix.c.
Apr 9 2021, 12:57 PM
zec updated subscribers of D29661: Appease -Wsign-compare in radix.c.
Apr 9 2021, 9:59 AM

Apr 8 2021

zec added a comment to D29661: Appease -Wsign-compare in radix.c.

May you please provide a full context diff?
I can't see, why the compiler issued a warning and how the fix will break other things (i.e. logic errors)

Apr 8 2021, 10:11 PM
zec updated the diff for D29661: Appease -Wsign-compare in radix.c.

Expand the diff to -U30 per request from donner@.

Apr 8 2021, 10:10 PM
zec requested review of D29661: Appease -Wsign-compare in radix.c.
Apr 8 2021, 9:40 PM
zec added inline comments to D29588: [FIB algo] Add support for the batched updates..
Apr 8 2021, 9:04 PM

Dec 13 2020

zec committed R9:c367f0a18724: Add myself to the list. (authored by zec).
Add myself to the list.
Dec 13 2020, 5:46 PM
zec committed R9:4ab1878453ac: Add myself to the list. (authored by zec).
Add myself to the list.
Dec 13 2020, 5:46 PM