In D45091#1028305, @diizzy wrote:

Seeing that this is a CLI game is there any need to include desktop related files?

PORTVERSION -> DISTVERSION
Add LICENSE_FILE

In D44791#1023899, @uzsolt wrote:

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

Here it is: https://github.com/pgbackrest/pgbackrest/commit/7b95fd3bd29346e7325aa161bfee45efd71e22eb
The port maintainer is the author of patch.

How should handle it in the port?

In D44791#1023359, @diizzy wrote:

Where do the patches originate and are they upstreamed?

In D44549#1023281, @diizzy wrote:

make test in ports tree (without Poudriere) on 14.0

In D44549#1023235, @diizzy wrote:

* checking package dependencies ... ERROR
Package required but not available: 'utils'

Packages suggested but not available for checking: 'Cairo', 'ragg'

See section 'The DESCRIPTION file' in the 'Writing R Extensions'
manual.
* DONE

Status: 1 ERROR
See
  '/usr/ports/textproc/R-cran-htmltools/work/htmltools.Rcheck/00check.log'
for details.

*** Error code 1

Update to 0.25.2.

Sorry, I forgot the PR link: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276490

Update to 0.32.4.

In D44416#1013971, @diizzy wrote:

Remember to credit submitter correctly using the ´git --commit´, reference PR and use Reviewed by: entry (don't forget to add previous version).

Use MASTER_SITES instead of USE_GITHUB.

In D44391#1012309, @diizzy wrote:

Whenever possible, use upstream release archive
https://github.com/Cloudef/bemenu/releases/tag/0.6.21

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github (read warning)

In D44293#1010454, @bofh wrote:

Oh damn. I simply forgot you are still under mentorship. :)

:)

In D44293#1010436, @bofh wrote:

Just in case you miss the other mail:

1. Commit with git commit --author NAME <email>
2. Remove Reported by:
3. Use Approved by: Submitter is maintainer

Planned commit message:

Remove PORTREVISION

Update to 6.18.1.
Portlint, portclippy, portfmt are ok.
Poudriere testport passed on amd64 13.2 and 14.0, both qt5 and qt6 flavors.

In D43880#1008337, @bofh wrote:

I thought I said Ship It. :D

In D43880#1008066, @bofh wrote:

As mentioned earlier poudriere's lib detection method is not too robust and might not be the correct way to follow. So do not blindly remove those and retest like you have done here. curl should stay if it throws an error while absent.

In D44179#1008268, @bofh wrote:

Although the patch looks fine to me the planned commit message is not.

Thanks for fixes. Will be good the commit message below?

Fix REINPLACE_CMD.

In D44179#1008047, @bofh wrote:

This is a bit awkward that you are running sed twice on the same file. These should be really avoided because this is what happens in the background:

1. The first time it is run there is a new Makefile.bak
2. The second time it is run that Makefile.bak is overwritten with the Makefile altered at first stage
3. So the original Makefile is lost

Yes, you've right.