User Details
- User Since
- Aug 2 2014, 8:08 AM (509 w, 6 d)
Sun, Apr 28
I’m not sure how one would go about communicating this change, since it mostly affects developers (Relnotes: yes?), but I would probably send out a heads up about some of the function definitions changing (the extra ellipses), and provide rationale for why they’re changing in the commit. It could confuse developers who use more naive methods of searching for function definitions (like me :)..). All the more reason to encourage others to use alternative tools like cscope or VSCode :).
Sat, Apr 27
Sun, Apr 21
-Wl,-Bsymbolic should be added to SOLINKOPTS instead of LDFLAGS
Fix the change to properly append the CFLAG to PICFLAG and do it after including bsd.lib.mk to properly compile/link libcrypto.so.
I accidentally pushed this to main. I've really become used to git push.default nothing thanks to being bitten so much at work and forgot that my local forks don't use this config by default :(..
Mar 27 2024
Mar 3 2024
Jan 31 2024
Jan 18 2024
I held off on this review for a while, but I wanted to chime in about a few things:
Dec 18 2023
Nov 23 2023
Nov 20 2023
Would you please add a comment to the tops of functions to note what variables are being set in the functions?
Nov 14 2023
Oct 28 2023
Oct 24 2023
Also, please add comments for non-obvious things: you have the context now, but I didn't understand the reasoning, and you might not have the context at a later date. The code needs to either be intuitive by design or intuitive via comments.
Ok, that part wasn't apparent before.
Oct 21 2023
Oct 15 2023
Should this still be open, given that you have done a functionally equivalent change in D41970?
Oct 4 2023
All of my questions relate to understanding the rationale behind some of the design choices presented in the change.
Oct 3 2023
Oct 2 2023
Sep 29 2023
No ship-blocking comments.
Thank you 🙂!!
Sep 27 2023
Please don't modify the NetBSD test: if the plan is to test out FreeBSD-specific behavior for strcmp, it should go in its own test.
Sep 26 2023
Sep 22 2023
Sep 6 2023
Awesome new tests!
Aug 31 2023
Thank you @lwhsu !
- Incorporate changes from @brd's patch attached to the PR
- Delete spurious whitespace added in a comment.
Aug 22 2023
Aug 21 2023
Thank you @fuz !
Does this change to contrib/netbsd-tests chase an upstream change, or is it changing the tests to accommodate this change?
I'm trying to reduce the amount of unnecessary change upstream so I can drop a new version of contrib/netbsd-tests, while also upstreaming all valid changes to NetBSD and it's become a bit difficult in some areas where folks have added FreeBSD-specific tests to contrib/netbsd-tests (which was not my original intent).
(FWIW I'm not saying this change is bad -- I'm just trying to stop this from being automatically seen as mergeable)
Aug 19 2023
Aug 18 2023
Accepting so the affected port's build can be unbroken.
dh_depr.c and dsa_depr.c are missing.
There are other deprecated APIs that we might want to include apart from just rsa_depr.c:
./crypto/openssl/apps/lib/tlssrp_depr.c ./crypto/openssl/crypto/dh/dh_depr.c ./crypto/openssl/crypto/rsa/rsa_depr.c ./crypto/openssl/crypto/dsa/dsa_depr.c ./crypto/openssl/crypto/bn/bn_depr.c ./crypto/openssl/ssl/tls_depr.c
This is the right thing to do, given that this gets compiled/linked in unconditionally upstream.
Aug 16 2023
Aug 11 2023
Aug 10 2023
Aug 9 2023
Add expected failure from 1.10.0